third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media-expected.txt - Issue 2334803002: Implementation of media controls download button.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media-expected.txt

Issue 2334803002: Implementation of media controls download button. (Closed)

Patch Set: --no-find-copies Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Downloading URL with suggested filename ""
	whywhat 2016/09/13 15:52:16 I trust that this actually verifies the download : I trust that this actually verifies the download :) (I assume this is the same way MediaDocument download is tested). It's just not very explicit :) Maybe add a comment above waitUntilExternalURLLoad that this is the test's exit condition? kdsilva 2016/09/13 17:33:01 Done. MediaDocument isn't testing this functionali Show quoted text On 2016/09/13 15:52:16, whywhat wrote: > I trust that this actually verifies the download :) (I assume this is the same > way MediaDocument download is tested). It's just not very explicit :) Maybe add > a comment above waitUntilExternalURLLoad that this is the test's exit condition? Done. MediaDocument isn't testing this functionality (so far as I could tell), but I found other examples of people using this way of testing download functionality.
	2

OLD	NEW