Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2334773003: Support sample rates up to 384 kHz. (Closed)
Patch Set: Mark old histograms obsolete Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index edfe252772965e0350e02f6d75f453a54ef84ed6..60f1d69364fe032ddd4a0d63efe63ba79c1c3aad 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -65830,6 +65830,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="WebAudio.AudioBuffer.SampleRate" units="Hz">
+ <obsolete>
+ Replaced by SampleRate384k in Issue 644683 on 2016/09 due to higher
+ supported sample rates.
+ </obsolete>
+ <owner>rtoy@chromium.org</owner>
+ <owner>hongchan@chromium.org</owner>
+ <summary>
+ The sample rate (in Hz) requested by createBuffer(). Recorded for every call
+ to createBuffer(). Probably many (tens or hundreds) per page.
+ </summary>
+</histogram>
+
+<histogram name="WebAudio.AudioBuffer.SampleRate384" units="Hz">
Mark P 2016/09/15 23:16:31 You left off the "k" in the histogram name. Also,
Raymond Toy 2016/10/10 16:28:32 Renamed them all to say "384kHz".
<owner>rtoy@chromium.org</owner>
<owner>hongchan@chromium.org</owner>
<summary>
@@ -65839,6 +65852,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="WebAudio.AudioBuffer.SampleRateRatio">
+ <obsolete>
+ Replaced by SampleRateRatio384k in Issue 644683 on 2016/09 due to higher
+ supported sample rates.
+ </obsolete>
+ <owner>rtoy@chromium.org</owner>
+ <owner>hongchan@chromium.org</owner>
+ <summary>
+ The ratio of the buffer sample rate from createBuffer() to the context
+ sample rate. This indicates if the buffer needs to be resampled. Recorded
+ for every call to createBuffer(). Probably many (tens or hundreds) per
+ page.
+ </summary>
+</histogram>
+
+<histogram name="WebAudio.AudioBuffer.SampleRateRatio384k">
<owner>rtoy@chromium.org</owner>
<owner>hongchan@chromium.org</owner>
<summary>
@@ -65961,6 +65989,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="WebAudio.OfflineAudioContext.SampleRate384k" units="Hz">
+ <owner>rtoy@chromium.org</owner>
+ <owner>hongchan@chromium.org</owner>
+ <summary>
+ The sample rate (in Hz) specified for the offline audio context. Recorded
+ for every offline context created. Probably only a few per page, but could
+ be potentially much more (thousands).
+ </summary>
+</histogram>
+
<histogram name="WebAudio.PannerNode.PanningModel" enum="PanningModelType">
<owner>rtoy@chromium.org</owner>
<owner>hongchan@chromium.org</owner>

Powered by Google App Engine
This is Rietveld 408576698