third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt - Issue 2334773003: Support sample rates up to 384 kHz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt

Issue 2334773003: Support sample rates up to 384 kHz. (Closed)

Patch Set: Mark old histograms obsolete Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor.html ('k') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt

diff --git a/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt b/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt

index 7633da3ad64cd9b5c490b908e31bfb9993c7b1cc..04ff2afa14f6ceaa6d0cfec338a12daa62a497ea 100644

--- a/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt

+++ b/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt

@@ -4,10 +4,12 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

PASS new OfflineAudioContext(1, 0, 44100) threw exception SyntaxError: Failed to construct 'OfflineAudioContext': number of frames cannot be zero..

+PASS context = new OfflineAudioContext(2, 512, 2999) threw exception IndexSizeError: Failed to construct 'OfflineAudioContext': The sampleRate provided (2999) is outside the range [3000, 384000]..

hongchan 2016/09/26 17:17:54 Hmm. Why is this IndexSizedError? Shouldn't this b

Raymond Toy 2016/09/26 17:35:09 That appears to be a bug. The spec doesn't say ex

PASS context = new OfflineAudioContext(2, 512, 3000) did not throw exception.

PASS context.length is 512

-PASS context = new OfflineAudioContext(2, 1024, 192000) did not throw exception.

+PASS context = new OfflineAudioContext(2, 1024, 384000) did not throw exception.

PASS context.length is 1024

+PASS context = new OfflineAudioContext(2, 1024, 384001) threw exception IndexSizeError: Failed to construct 'OfflineAudioContext': The sampleRate provided (384001) is outside the range [3000, 384000]..

hongchan 2016/09/26 17:17:54 Ditto.

PASS context = new OfflineAudioContext(2, 2048, 8000) did not throw exception.

PASS context.length is 2048

PASS context = new OfflineAudioContext(2, 4096, 11025) did not throw exception.