Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2334763002: Testing support for FF and Safari (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 3 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Testing support for FF and Safari Also travis support for testing FF. See: https://travis-ci.org/dart-lang/sdk/builds/159331789 On FF 48, 1965 out of 1979 tests are passing. Run locally: DDC_BROWSERS=Firefox npm test On Safari 10 (tech preview), it fails immediately due to a static method named "caller". We disallow it as a field, but not a method right now. If I hack that out, 1972 out of 1979 tests appear to pass. Run locally by installing tech preview and running: DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test R=jmesserly@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9732138317888b33d7fa8e164922e0a0ccae458c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M .travis.yml View 3 chunks +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/karma.conf.js View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/package.json View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
vsm
https://codereview.chromium.org/2334763002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2334763002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode512 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:512: for (let callback of $callbacks) { FF isn't happy ...
4 years, 3 months ago (2016-09-12 14:47:50 UTC) #3
Bob Nystrom
LGTM, however I'm not familiar with Travis configs or Karma.
4 years, 3 months ago (2016-09-13 21:28:29 UTC) #4
Jennifer Messerly
LGTM!
4 years, 3 months ago (2016-09-13 21:52:57 UTC) #5
vsm
4 years, 3 months ago (2016-09-14 15:41:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9732138317888b33d7fa8e164922e0a0ccae458c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698