[Clock sync] Use clock sync manager to convert trace event timestamps

[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

To make telemetry's integration test of tracing on reference Chrome 
binary passing, this CL also fixes how trace importers handle clock 
sync events based on telemetry's workaround of using console.time 
& console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e7bc5cd441bd56/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py#L153)

This is based on charliea@'s original work in https://codereview.chromium.org/2203033002/

BUG=catapult:#2547

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/260117fe0d2e76f878268a4c84e23ba0332e1329

[nednguyen, 2016-09-12 14:31:16]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 14:31:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 14:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 14:45:16]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen, 2016-09-12 15:49:41]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:49:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-09-12 15:49:51]

nednguyen@google.com changed reviewers:
+ charliea@chromium.org

[nednguyen, 2016-09-12 15:50:14]

Description was changed from

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

BUG=catapult:#2547
==========

to

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.


This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

[nednguyen, 2016-09-12 18:53:19]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 18:53:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-09-12 18:55:04]

On 2016/09/12 15:49:52, nednguyen wrote:

PTAL: this is ready for review.

[commit-bot: I haz the power, 2016-09-12 19:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 19:14:56]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-09-12 21:23:56]

Description was changed from

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.


This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

to

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

This CL also fixes how trace importers handle clock sync events
based on telemetry's workaround of using console.time & console.timeEnd for
record clock sync on old chrome binary (see
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)


This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

[nednguyen, 2016-09-12 21:24:08]

Description was changed from

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

This CL also fixes how trace importers handle clock sync events
based on telemetry's workaround of using console.time & console.timeEnd for
record clock sync on old chrome binary (see
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)


This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

to

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

This CL also fixes how trace importers handle clock sync events
based on telemetry's workaround of using console.time & 
console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)


This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

[nednguyen, 2016-09-12 21:28:48]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:28:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-09-12 21:30:33]

Description was changed from

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

This CL also fixes how trace importers handle clock sync events
based on telemetry's workaround of using console.time & 
console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)


This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

to

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

This CL also fixes how trace importers handle clock sync events
based on telemetry's workaround of using console.time & 
console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)

This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

[nednguyen, 2016-09-12 21:42:45]

On 2016/09/12 18:55:04, nednguyen wrote:
> On 2016/09/12 15:49:52, nednguyen wrote:
> 
> PTAL: this is ready for review.

I just verified that this indeed fixes
https://github.com/catapult-project/catapult/issues/2759. Applying this patch on
the trace in
https://github.com/catapult-project/catapult/issues/2759#issue-174801151 gives
us the correct view now :-)

[nednguyen, 2016-09-12 21:48:34]

Description was changed from

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

This CL also fixes how trace importers handle clock sync events
based on telemetry's workaround of using console.time & 
console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)

This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

to

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

To make telemetry's integration test of tracing on reference Chrome 
binary passing, this CL also fixes how trace importers handle clock 
sync events based on telemetry's workaround of using console.time 
& console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)

This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

[nednguyen, 2016-09-12 21:53:26]

nednguyen@google.com changed reviewers:
+ fmeawad@chromium.org, nduca@chromium.org

[nednguyen, 2016-09-12 21:53:27]

+Fadi, Nat since I would want this patch lands soon to unblock
https://codereview.chromium.org/2301523007/

[commit-bot: I haz the power, 2016-09-12 21:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:53:46]

Dry run: This issue passed the CQ dry run.

[nduca, 2016-09-12 21:57:39]

lgtm with nit

https://codereview.chromium.org/2334753002/diff/80001/tracing/tracing/extras/...
File tracing/tracing/extras/importer/trace_event_importer.html (right):

https://codereview.chromium.org/2334753002/diff/80001/tracing/tracing/extras/...
tracing/tracing/extras/importer/trace_event_importer.html:894: // Older version
of Chrome doesn't support clock sync API, hence
can you extract this out to a function?

eg
initBackcompatClockSyncEventTracker(e) and
checkEventForBackcompatClockSyncEventAndDispatch(e)

[nednguyen, 2016-09-12 22:43:24]

https://codereview.chromium.org/2334753002/diff/80001/tracing/tracing/extras/...
File tracing/tracing/extras/importer/trace_event_importer.html (right):

https://codereview.chromium.org/2334753002/diff/80001/tracing/tracing/extras/...
tracing/tracing/extras/importer/trace_event_importer.html:894: // Older version
of Chrome doesn't support clock sync API, hence
On 2016/09/12 21:57:39, nduca wrote:
> can you extract this out to a function?
> 
> eg
> initBackcompatClockSyncEventTracker(e) and
> checkEventForBackcompatClockSyncEventAndDispatch(e)

Done.

[nednguyen, 2016-09-12 22:47:15]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-09-12 22:47:16]

The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/2334753002/#ps120001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-09-12 22:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:08:51]

Description was changed from

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

To make telemetry's integration test of tracing on reference Chrome 
binary passing, this CL also fixes how trace importers handle clock 
sync events based on telemetry's workaround of using console.time 
& console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)

This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547
==========

to

==========
[Clock sync] Use clock sync manager to convert trace event timestamps

This is usually a no-op because we always try to use the Chrome clock
domain as the model clock domain. However, without actually getting
a model time transformer for the trace event importer, we never verify
that all of the clock domains are connected.

To make telemetry's integration test of tracing on reference Chrome 
binary passing, this CL also fixes how trace importers handle clock 
sync events based on telemetry's workaround of using console.time 
& console.timeEnd for record clock sync on old chrome binary (see 
https://github.com/catapult-project/catapult/blob/cb0d9d7c3b28514bb03d9cc1f1e...)

This is based on charliea@'s original work in
https://codereview.chromium.org/2203033002/

BUG=catapult:#2547

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-09-12 23:08:52]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...