Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/Panel.js

Issue 2334693003: Add ARIA markup for tabs & tab panels (Closed)
Patch Set: forgot changing two aria-expanded attributes to aria-selected Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 17 matching lines...) Expand all
28 28
29 /** 29 /**
30 * @extends {WebInspector.VBox} 30 * @extends {WebInspector.VBox}
31 * @constructor 31 * @constructor
32 */ 32 */
33 WebInspector.Panel = function(name) 33 WebInspector.Panel = function(name)
34 { 34 {
35 WebInspector.VBox.call(this); 35 WebInspector.VBox.call(this);
36 36
37 this.element.classList.add("panel"); 37 this.element.classList.add("panel");
38 this.element.setAttribute("role", "tabpanel");
39 this.element.setAttribute("aria-label", name);
38 this.element.classList.add(name); 40 this.element.classList.add(name);
39 this._panelName = name; 41 this._panelName = name;
40 42
41 this._shortcuts = /** !Object.<number, function(Event=):boolean> */ ({}); 43 this._shortcuts = /** !Object.<number, function(Event=):boolean> */ ({});
42 } 44 }
43 45
44 // Should by in sync with style declarations. 46 // Should by in sync with style declarations.
45 WebInspector.Panel.counterRightMargin = 25; 47 WebInspector.Panel.counterRightMargin = 25;
46 48
47 WebInspector.Panel.prototype = { 49 WebInspector.Panel.prototype = {
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 228
227 /** 229 /**
228 * @override 230 * @override
229 * @return {!Promise.<!WebInspector.Panel>} 231 * @return {!Promise.<!WebInspector.Panel>}
230 */ 232 */
231 panel: function() 233 panel: function()
232 { 234 {
233 return /** @type {!Promise<!WebInspector.Panel>} */(this._extension.ins tance()); 235 return /** @type {!Promise<!WebInspector.Panel>} */(this._extension.ins tance());
234 } 236 }
235 } 237 }
OLDNEW
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698