Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Issue 2334633002: [turbofan] Ship eval. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship eval. No longer disable TurboFan for functions with eval, but only disable Crankshaft in those cases. R=mstarzinger@chromium.org BUG=v8:5267 Committed: https://crrev.com/f0a0c432a5d048d39f250a7bb20d662d14e1cd17 Cr-Commit-Position: refs/heads/master@{#39338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-12 09:09:52 UTC) #1
Michael Starzinger
LGTM (rubber-stamp).
4 years, 3 months ago (2016-09-12 09:16:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334633002/1
4 years, 3 months ago (2016-09-12 09:16:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 09:40:54 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 09:41:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0a0c432a5d048d39f250a7bb20d662d14e1cd17
Cr-Commit-Position: refs/heads/master@{#39338}

Powered by Google App Engine
This is Rietveld 408576698