components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc - Issue 2334623003: Store net::ProxyServer in HttpResponseInfo object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

Issue 2334623003: Store net::ProxyServer in HttpResponseInfo object (Closed)

Patch Set: Rebased, fix compile error Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

index bdb0d476a71afd95298b865bef4012cede5b5a08..b9a4168edbcff688e38b2d144cbd0bf8fec99b49 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

@@ -55,7 +55,8 @@ DataReductionProxyRequestType GetDataReductionProxyRequestType(

// due to other proxies overriding the Data Reduction Proxy, and bypasses due

// to local bypass rules.

if ((request.load_flags() & net::LOAD_BYPASS_PROXY) ||

- (!request.proxy_server().IsEmpty() &&

+ (request.proxy_server().is_valid() &&

+ !request.proxy_server().is_direct() &&

!config.IsDataReductionProxy(request.proxy_server(), NULL)) ||

config.IsBypassedByDataReductionProxyLocalRules(

request, data_reduction_proxy_config)) {