Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 2334623003: Store net::ProxyServer in HttpResponseInfo object (Closed)
Patch Set: Rebased, fix compile error Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/cronet_url_request_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc
index e0820aa46b6db0584abd0cd4147aaa33b0d02f9b..75362cde1e468b071d890d58324fb6d554b3a485 100644
--- a/components/cronet/android/cronet_url_request_adapter.cc
+++ b/components/cronet/android/cronet_url_request_adapter.cc
@@ -23,6 +23,7 @@
#include "net/http/http_response_headers.h"
#include "net/http/http_status_code.h"
#include "net/http/http_util.h"
+#include "net/proxy/proxy_server.h"
#include "net/quic/core/quic_protocol.h"
#include "net/ssl/ssl_info.h"
#include "net/url_request/redirect_info.h"
@@ -47,6 +48,14 @@ int64_t ConvertTime(const base::TimeTicks& ticks,
return (start_time + (ticks - start_ticks)).ToJavaTime();
}
+// Returns the string representation of the HostPortPair of the proxy server
+// that was used to fetch the response.
+std::string GetProxy(const net::HttpResponseInfo& info) {
+ if (!info.proxy_server.is_valid() || info.proxy_server.is_direct())
+ return net::HostPortPair().ToString();
+ return info.proxy_server.host_port_pair().ToString();
+}
+
} // namespace
// Explicitly register static JNI functions.
@@ -227,9 +236,7 @@ void CronetURLRequestAdapter::OnReceivedRedirect(
ConvertUTF8ToJavaString(env,
request->response_info().alpn_negotiated_protocol)
.obj(),
- ConvertUTF8ToJavaString(env,
- request->response_info().proxy_server.ToString())
- .obj(),
+ ConvertUTF8ToJavaString(env, GetProxy(request->response_info())).obj(),
request->GetTotalReceivedBytes());
*defer_redirect = true;
}
@@ -276,9 +283,7 @@ void CronetURLRequestAdapter::OnResponseStarted(net::URLRequest* request,
ConvertUTF8ToJavaString(env,
request->response_info().alpn_negotiated_protocol)
.obj(),
- ConvertUTF8ToJavaString(env,
- request->response_info().proxy_server.ToString())
- .obj());
+ ConvertUTF8ToJavaString(env, GetProxy(request->response_info())).obj());
}
void CronetURLRequestAdapter::OnReadCompleted(net::URLRequest* request,
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698