chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/policy/javascript_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

diff --git a/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc b/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

index 47979ca311bbc2ed6c8e55dbdc6fce82cca98bfb..99dd83970ce9e875625dd6fed63a84dcadaec2a8 100644

--- a/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

+++ b/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

@@ -31,7 +31,7 @@ TEST_F(FileSelectionDialogsPolicyTest, Default) {

TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {

policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(true)), nullptr);

+ base::MakeUnique<base::FundamentalValue>(true), nullptr);

handler_.ApplyPolicySettings(policy_, &prefs_);

// Allowing file-selection dialogs should not influence the PromptForDownload

@@ -42,7 +42,7 @@ TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {

TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) {

policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(false)), nullptr);

+ base::MakeUnique<base::FundamentalValue>(false), nullptr);

handler_.ApplyPolicySettings(policy_, &prefs_);

// Disabling file-selection dialogs should disable the PromptForDownload pref.