Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6498)

Unified Diff: chrome/browser/policy/cloud/cloud_policy_browsertest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/cloud_policy_browsertest.cc
diff --git a/chrome/browser/policy/cloud/cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
index 90b3fffb1867d5e183caa0c53fbf780687fa7194..dc8ed43e8dab5110de72a1f2eb96d9fa3fbadd75 100644
--- a/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
+++ b/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
@@ -85,9 +85,9 @@ namespace {
std::unique_ptr<KeyedService> BuildFakeProfileInvalidationProvider(
content::BrowserContext* context) {
- return base::WrapUnique(new invalidation::ProfileInvalidationProvider(
+ return base::MakeUnique<invalidation::ProfileInvalidationProvider>(
std::unique_ptr<invalidation::InvalidationService>(
- new invalidation::FakeInvalidationService)));
+ new invalidation::FakeInvalidationService));
}
#if !defined(OS_CHROMEOS)
@@ -153,26 +153,26 @@ void GetExpectedDefaultPolicy(PolicyMap* policy_map) {
POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
base::WrapUnique(new base::FundamentalValue(false)), nullptr);
#if defined(OS_CHROMEOS)
- policy_map->Set(
- key::kChromeOsMultiProfileUserBehavior, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
- base::WrapUnique(new base::StringValue("primary-only")), nullptr);
+ policy_map->Set(key::kChromeOsMultiProfileUserBehavior,
+ POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ POLICY_SOURCE_ENTERPRISE_DEFAULT,
+ base::MakeUnique<base::StringValue>("primary-only"), nullptr);
policy_map->Set(key::kEasyUnlockAllowed, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
- base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(false), nullptr);
policy_map->Set(key::kCaptivePortalAuthenticationIgnoresProxy,
POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_ENTERPRISE_DEFAULT,
- base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(false), nullptr);
policy_map->Set(key::kAllowDinosaurEasterEgg, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
- base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(false), nullptr);
policy_map->Set(key::kArcEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_ENTERPRISE_DEFAULT,
- base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(false), nullptr);
policy_map->Set(key::kPacHttpsUrlStrippingEnabled, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
- base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(false), nullptr);
#endif
}
@@ -181,10 +181,10 @@ void GetExpectedTestPolicy(PolicyMap* expected, const char* homepage) {
expected->Set(key::kShowHomeButton, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::FundamentalValue(true)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(true), nullptr);
expected->Set(key::kRestoreOnStartup, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::FundamentalValue(4)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(4), nullptr);
base::ListValue list;
list.AppendString("dev.chromium.org");
list.AppendString("youtube.com");
@@ -192,10 +192,10 @@ void GetExpectedTestPolicy(PolicyMap* expected, const char* homepage) {
POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), nullptr);
expected->Set(key::kMaxInvalidationFetchDelay, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::FundamentalValue(1000)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(1000), nullptr);
expected->Set(key::kHomepageLocation, POLICY_LEVEL_RECOMMENDED,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::StringValue(homepage)), nullptr);
+ base::MakeUnique<base::StringValue>(homepage), nullptr);
}
} // namespace
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | chrome/browser/policy/cloud/policy_header_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698