chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_initialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

index c99e2569e650b13c397c9d121109b2f2d1808184..de5c3ce6e621a8f457d7bea622edd0c784e34075 100644

--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

@@ -19,7 +19,7 @@ class ServiceWorkerPageLoadMetricsObserverTest

protected:

void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {

tracker->AddObserver(

- base::WrapUnique(new ServiceWorkerPageLoadMetricsObserver()));

+ base::MakeUnique<ServiceWorkerPageLoadMetricsObserver>());

}

void SimulateTimingWithoutPaint() {