Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5119)

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_notification_manager.cc
diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc
index 99cc5904e7c555c5b33e2046ab3b096aeef67340..ef2e3ccc2de027229508dc8e0796ca9aecf099bd 100644
--- a/chrome/browser/notifications/message_center_notification_manager.cc
+++ b/chrome/browser/notifications/message_center_notification_manager.cc
@@ -57,14 +57,14 @@ MessageCenterNotificationManager::MessageCenterNotificationManager(
message_center_->SetNotifierSettingsProvider(settings_provider_.get());
#if defined(OS_CHROMEOS)
- blockers_.push_back(base::WrapUnique(
- new LoginStateNotificationBlockerChromeOS(message_center)));
+ blockers_.push_back(
+ base::MakeUnique<LoginStateNotificationBlockerChromeOS>(message_center));
#else
blockers_.push_back(
- base::WrapUnique(new ScreenLockNotificationBlocker(message_center)));
+ base::MakeUnique<ScreenLockNotificationBlocker>(message_center));
#endif
blockers_.push_back(
- base::WrapUnique(new FullscreenNotificationBlocker(message_center)));
+ base::MakeUnique<FullscreenNotificationBlocker>(message_center));
#if defined(OS_WIN) || defined(OS_MACOSX) \
|| (defined(OS_LINUX) && !defined(OS_CHROMEOS))
@@ -116,8 +116,9 @@ void MessageCenterNotificationManager::Add(const Notification& notification,
AddNotificationToAlternateProvider(profile_notification->notification(),
profile, extension_id);
- message_center_->AddNotification(base::WrapUnique(
- new message_center::Notification(profile_notification->notification())));
+ message_center_->AddNotification(
+ base::MakeUnique<message_center::Notification>(
+ profile_notification->notification()));
}
bool MessageCenterNotificationManager::Update(const Notification& notification,
@@ -161,8 +162,8 @@ bool MessageCenterNotificationManager::Update(const Notification& notification,
// center via the notification within a ProfileNotification object or the
// profile ID will not be correctly set for ChromeOS.
message_center_->UpdateNotification(
- old_id, base::WrapUnique(new message_center::Notification(
- new_notification->notification())));
+ old_id, base::MakeUnique<message_center::Notification>(
+ new_notification->notification()));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698