chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc ('k') | chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

index 1f8d40975f3e098c0a4a083db010dc6b38dc3135..16c9d1091d02d25c2b5848269a95fef1535e1471 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc

@@ -24,8 +24,7 @@ using testing::Return;

class DataReductionProxyChromeSettingsTest : public testing::Test {

public:

void SetUp() override {

- drp_chrome_settings_ =

- base::WrapUnique(new DataReductionProxyChromeSettings());

+ drp_chrome_settings_ = base::MakeUnique<DataReductionProxyChromeSettings>();

test_context_ =

data_reduction_proxy::DataReductionProxyTestContext::Builder()

.WithMockConfig()

@@ -33,7 +32,7 @@ class DataReductionProxyChromeSettingsTest : public testing::Test {

.Build();

config_ = test_context_->mock_config();

drp_chrome_settings_->ResetConfigForTest(config_);

- dict_ = base::WrapUnique(new base::DictionaryValue());

+ dict_ = base::MakeUnique<base::DictionaryValue>();

PrefRegistrySimple* registry = test_context_->pref_service()->registry();

registry->RegisterDictionaryPref(proxy_config::prefs::kProxy);