Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4519)

Unified Diff: chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/disk_cache_dir_policy_handler.cc ('k') | chrome/browser/net/errorpage_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
diff --git a/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc b/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
index ee0425aa1e03da0e1eca80c34fea3679fc9fe987..a716025ee9ad01125dc6441b42f39c7e70442e5b 100644
--- a/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
+++ b/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
@@ -32,7 +32,7 @@ TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) {
// DiskCacheDir policy expects a string; give it a boolean.
policy_.Set(key::kDiskCacheDir, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+ base::MakeUnique<base::FundamentalValue>(false), nullptr);
handler_.ApplyPolicySettings(policy_, &prefs_);
EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
}
@@ -41,7 +41,7 @@ TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) {
// Use a variable in the value. It should be expanded by the handler.
const std::string in = "${user_name}/foo";
policy_.Set(key::kDiskCacheDir, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD, base::WrapUnique(new base::StringValue(in)),
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(in),
nullptr);
handler_.ApplyPolicySettings(policy_, &prefs_);
« no previous file with comments | « chrome/browser/net/disk_cache_dir_policy_handler.cc ('k') | chrome/browser/net/errorpage_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698