chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc

diff --git a/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc b/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc

index 58094e3609b553f16be71c61ff5d387224a1164e..45a840e55d993b0ef84a526fe5388953fb357dab 100644

--- a/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc

+++ b/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc

@@ -288,7 +288,7 @@ TEST_F(WebRtcLogUploaderTest, AddRtpDumpsToPostedData) {

std::unique_ptr<WebRtcLogBuffer> log(new WebRtcLogBuffer());

log->SetComplete();

webrtc_log_uploader->LoggingStoppedDoUpload(

- std::move(log), base::WrapUnique(new MetaDataMap()), upload_done_data);

+ std::move(log), base::MakeUnique<MetaDataMap>(), upload_done_data);

VerifyRtpDumpInMultipart(post_data, "rtpdump_recv", incoming_dump_content);

VerifyRtpDumpInMultipart(post_data, "rtpdump_send", outgoing_dump_content);