chrome/browser/android/history_report/delta_file_backend_leveldb.cc - Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/history_report/delta_file_backend_leveldb.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)

Patch Set: Changes from review by sky Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/data_usage/data_use_matcher.cc ('k') | chrome/browser/android/omnibox/autocomplete_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/history_report/delta_file_backend_leveldb.cc

diff --git a/chrome/browser/android/history_report/delta_file_backend_leveldb.cc b/chrome/browser/android/history_report/delta_file_backend_leveldb.cc

index b9f04e307f66f59efb3c2db9cf7e974d25a32674..8afea6fea2f7b2a1d7f45b8df2c567f918129d37 100644

--- a/chrome/browser/android/history_report/delta_file_backend_leveldb.cc

+++ b/chrome/browser/android/history_report/delta_file_backend_leveldb.cc

@@ -196,7 +196,7 @@ std::unique_ptr<std::vector<DeltaFileEntryWithData>> DeltaFileBackend::Query(

int64_t last_seq_no,

int32_t limit) {

if (!EnsureInitialized())

- return base::WrapUnique(new std::vector<DeltaFileEntryWithData>());

+ return base::MakeUnique<std::vector<DeltaFileEntryWithData>>();

std::string start;

base::SStringPrintf(&start, "%" PRId64, last_seq_no + 1);

leveldb::ReadOptions options;