Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/android/compositor/tab_content_manager.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/compositor/tab_content_manager.cc
diff --git a/chrome/browser/android/compositor/tab_content_manager.cc b/chrome/browser/android/compositor/tab_content_manager.cc
index 8d5067848ac51051380c927708ce45887bf2f6c5..23690342e0842fe4380ec957a865888c0eaebce9 100644
--- a/chrome/browser/android/compositor/tab_content_manager.cc
+++ b/chrome/browser/android/compositor/tab_content_manager.cc
@@ -112,10 +112,10 @@ TabContentManager::TabContentManager(JNIEnv* env,
jint write_queue_max_size,
jboolean use_approximation_thumbnail)
: weak_java_tab_content_manager_(env, obj), weak_factory_(this) {
- thumbnail_cache_ = base::WrapUnique(new ThumbnailCache(
+ thumbnail_cache_ = base::MakeUnique<ThumbnailCache>(
(size_t)default_cache_size, (size_t)approximation_cache_size,
sky 2016/09/12 17:13:36 Fix these too static_cast?
Adam Rice 2016/09/13 03:02:49 I was trying to pretend I hadn't seen those. Fixed
(size_t)compression_queue_max_size, (size_t)write_queue_max_size,
- use_approximation_thumbnail));
+ use_approximation_thumbnail);
thumbnail_cache_->AddThumbnailCacheObserver(this);
}
@@ -237,8 +237,8 @@ void TabContentManager::CacheTab(JNIEnv* env,
base::Bind(&TabContentManager::PutThumbnailIntoCache,
weak_factory_.GetWeakPtr(), tab_id);
pending_tab_readbacks_.set(
- tab_id, base::WrapUnique(new TabReadbackRequest(
- web_contents, thumbnail_scale, readback_done_callback)));
+ tab_id, base::MakeUnique<TabReadbackRequest>(
+ web_contents, thumbnail_scale, readback_done_callback));
}
}

Powered by Google App Engine
This is Rietveld 408576698