Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/browser/sync/sync_error_notifier_ash_unittest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_error_notifier_ash.h" 5 #include "chrome/browser/sync/sync_error_notifier_ash.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 private: 72 private:
73 // LoginUIService::LoginUI: 73 // LoginUIService::LoginUI:
74 void FocusUI() override { ++focus_ui_call_count_; } 74 void FocusUI() override { ++focus_ui_call_count_; }
75 75
76 int focus_ui_call_count_; 76 int focus_ui_call_count_;
77 }; 77 };
78 78
79 std::unique_ptr<KeyedService> BuildMockLoginUIService( 79 std::unique_ptr<KeyedService> BuildMockLoginUIService(
80 content::BrowserContext* profile) { 80 content::BrowserContext* profile) {
81 return base::WrapUnique(new FakeLoginUIService()); 81 return base::MakeUnique<FakeLoginUIService>();
82 } 82 }
83 83
84 class SyncErrorNotifierTest : public AshTestBase { 84 class SyncErrorNotifierTest : public AshTestBase {
85 public: 85 public:
86 SyncErrorNotifierTest() {} 86 SyncErrorNotifierTest() {}
87 ~SyncErrorNotifierTest() override {} 87 ~SyncErrorNotifierTest() override {}
88 88
89 void SetUp() override { 89 void SetUp() override {
90 DCHECK(TestingBrowserProcess::GetGlobal()); 90 DCHECK(TestingBrowserProcess::GetGlobal());
91 91
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 SCOPED_TRACE("Not expecting notification since sync setup is incomplete"); 231 SCOPED_TRACE("Not expecting notification since sync setup is incomplete");
232 VerifySyncErrorNotifierResult( 232 VerifySyncErrorNotifierResult(
233 GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS, 233 GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS,
234 false /* not signed in */, 234 false /* not signed in */,
235 false /* no error */); 235 false /* no error */);
236 } 236 }
237 } 237 }
238 238
239 } // namespace test 239 } // namespace test
240 } // namespace ash 240 } // namespace ash
OLDNEW
« no previous file with comments | « chrome/browser/sync/profile_sync_test_util.cc ('k') | chrome/browser/sync/sync_global_error_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698