Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_services_manager_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_services_manager_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 184
185 if (!base::StringToInt(rate_str, rate) || *rate > 1000) 185 if (!base::StringToInt(rate_str, rate) || *rate > 1000)
186 return false; 186 return false;
187 187
188 return true; 188 return true;
189 } 189 }
190 190
191 std::unique_ptr<rappor::RapporService> 191 std::unique_ptr<rappor::RapporService>
192 ChromeMetricsServicesManagerClient::CreateRapporService() { 192 ChromeMetricsServicesManagerClient::CreateRapporService() {
193 DCHECK(thread_checker_.CalledOnValidThread()); 193 DCHECK(thread_checker_.CalledOnValidThread());
194 return base::WrapUnique(new rappor::RapporService( 194 return base::MakeUnique<rappor::RapporService>(
195 local_state_, base::Bind(&chrome::IsIncognitoSessionActive))); 195 local_state_, base::Bind(&chrome::IsIncognitoSessionActive));
196 } 196 }
197 197
198 std::unique_ptr<variations::VariationsService> 198 std::unique_ptr<variations::VariationsService>
199 ChromeMetricsServicesManagerClient::CreateVariationsService() { 199 ChromeMetricsServicesManagerClient::CreateVariationsService() {
200 DCHECK(thread_checker_.CalledOnValidThread()); 200 DCHECK(thread_checker_.CalledOnValidThread());
201 return variations::VariationsService::Create( 201 return variations::VariationsService::Create(
202 base::WrapUnique(new ChromeVariationsServiceClient()), local_state_, 202 base::MakeUnique<ChromeVariationsServiceClient>(), local_state_,
203 GetMetricsStateManager(), switches::kDisableBackgroundNetworking, 203 GetMetricsStateManager(), switches::kDisableBackgroundNetworking,
204 chrome_variations::CreateUIStringOverrider()); 204 chrome_variations::CreateUIStringOverrider());
205 } 205 }
206 206
207 std::unique_ptr<metrics::MetricsServiceClient> 207 std::unique_ptr<metrics::MetricsServiceClient>
208 ChromeMetricsServicesManagerClient::CreateMetricsServiceClient() { 208 ChromeMetricsServicesManagerClient::CreateMetricsServiceClient() {
209 DCHECK(thread_checker_.CalledOnValidThread()); 209 DCHECK(thread_checker_.CalledOnValidThread());
210 return ChromeMetricsServiceClient::Create(GetMetricsStateManager()); 210 return ChromeMetricsServiceClient::Create(GetMetricsStateManager());
211 } 211 }
212 212
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 ChromeMetricsServicesManagerClient::GetMetricsStateManager() { 273 ChromeMetricsServicesManagerClient::GetMetricsStateManager() {
274 DCHECK(thread_checker_.CalledOnValidThread()); 274 DCHECK(thread_checker_.CalledOnValidThread());
275 if (!metrics_state_manager_) { 275 if (!metrics_state_manager_) {
276 metrics_state_manager_ = metrics::MetricsStateManager::Create( 276 metrics_state_manager_ = metrics::MetricsStateManager::Create(
277 local_state_, enabled_state_provider_.get(), 277 local_state_, enabled_state_provider_.get(),
278 base::Bind(&PostStoreMetricsClientInfo), 278 base::Bind(&PostStoreMetricsClientInfo),
279 base::Bind(&GoogleUpdateSettings::LoadMetricsClientInfo)); 279 base::Bind(&GoogleUpdateSettings::LoadMetricsClientInfo));
280 } 280 }
281 return metrics_state_manager_.get(); 281 return metrics_state_manager_.get();
282 } 282 }
OLDNEW
« no previous file with comments | « chrome/browser/media_galleries/linux/mtp_read_file_worker.cc ('k') | chrome/browser/metrics/subprocess_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698