Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Issue 2334613003: Re-write many calls to WrapUnique() with MakeUnique() (Closed)
Patch Set: Changes from review by sky Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 case AdbMessage::kCommandOPEN: { 295 case AdbMessage::kCommandOPEN: {
296 DCHECK(current_message_->arg1 == 0); 296 DCHECK(current_message_->arg1 == 0);
297 DCHECK(current_message_->arg0 != 0); 297 DCHECK(current_message_->arg0 != 0);
298 std::string response; 298 std::string response;
299 WriteResponse(++last_local_socket_, 299 WriteResponse(++last_local_socket_,
300 current_message_->arg0, 300 current_message_->arg0,
301 AdbMessage::kCommandOKAY, 301 AdbMessage::kCommandOKAY,
302 std::string()); 302 std::string());
303 local_sockets_.set( 303 local_sockets_.set(
304 current_message_->arg0, 304 current_message_->arg0,
305 base::WrapUnique(new MockLocalSocket( 305 base::MakeUnique<MockLocalSocket>(
306 base::Bind(&MockUsbDeviceHandle::WriteResponse, 306 base::Bind(&MockUsbDeviceHandle::WriteResponse,
307 base::Unretained(this), last_local_socket_, 307 base::Unretained(this), last_local_socket_,
308 current_message_->arg0), 308 current_message_->arg0),
309 kDeviceSerial, current_message_->body.substr( 309 kDeviceSerial, current_message_->body.substr(
310 0, current_message_->body.size() - 1)))); 310 0, current_message_->body.size() - 1)));
311 return; 311 return;
312 } 312 }
313 default: { 313 default: {
314 return; 314 return;
315 } 315 }
316 } 316 }
317 ProcessQueries(); 317 ProcessQueries();
318 } 318 }
319 319
320 void WriteResponse(int arg0, int arg1, int command, const std::string& body) { 320 void WriteResponse(int arg0, int arg1, int command, const std::string& body) {
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 DevToolsAndroidBridgeWarmUp warmup(runner_->QuitClosure(), adb_bridge_); 541 DevToolsAndroidBridgeWarmUp warmup(runner_->QuitClosure(), adb_bridge_);
542 adb_bridge_->AddDeviceCountListener(&warmup); 542 adb_bridge_->AddDeviceCountListener(&warmup);
543 runner_->Run(); 543 runner_->Run();
544 runner_ = new content::MessageLoopRunner; 544 runner_ = new content::MessageLoopRunner;
545 } 545 }
546 }; 546 };
547 547
548 class AndroidUsbTraitsTest : public AndroidUsbDiscoveryTest { 548 class AndroidUsbTraitsTest : public AndroidUsbDiscoveryTest {
549 protected: 549 protected:
550 std::unique_ptr<MockUsbService> CreateMockService() override { 550 std::unique_ptr<MockUsbService> CreateMockService() override {
551 return base::WrapUnique(new MockUsbServiceForCheckingTraits()); 551 return base::MakeUnique<MockUsbServiceForCheckingTraits>();
552 } 552 }
553 }; 553 };
554 554
555 class AndroidBreakingUsbTest : public AndroidUsbDiscoveryTest { 555 class AndroidBreakingUsbTest : public AndroidUsbDiscoveryTest {
556 protected: 556 protected:
557 std::unique_ptr<MockUsbService> CreateMockService() override { 557 std::unique_ptr<MockUsbService> CreateMockService() override {
558 std::unique_ptr<MockUsbService> service(new MockUsbService()); 558 std::unique_ptr<MockUsbService> service(new MockUsbService());
559 service->AddDevice(new MockUsbDevice<BreakingAndroidTraits>()); 559 service->AddDevice(new MockUsbDevice<BreakingAndroidTraits>());
560 return service; 560 return service;
561 } 561 }
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 EXPECT_EQ(2, listener.invoked_); 764 EXPECT_EQ(2, listener.invoked_);
765 EXPECT_EQ(listener.invoked_ - 1, scheduler_invoked_); 765 EXPECT_EQ(listener.invoked_ - 1, scheduler_invoked_);
766 EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTesting()); 766 EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTesting());
767 } 767 }
768 768
769 IN_PROC_BROWSER_TEST_F(AndroidUsbTraitsTest, TestDeviceCounting) { 769 IN_PROC_BROWSER_TEST_F(AndroidUsbTraitsTest, TestDeviceCounting) {
770 MockCountListenerForCheckingTraits listener(adb_bridge_); 770 MockCountListenerForCheckingTraits listener(adb_bridge_);
771 adb_bridge_->AddDeviceCountListener(&listener); 771 adb_bridge_->AddDeviceCountListener(&listener);
772 runner_->Run(); 772 runner_->Run();
773 } 773 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/device/adb/mock_adb_server.cc ('k') | chrome/browser/devtools/device/usb/android_usb_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698