[Android] Add mechanism to disable double tap/drag zooming.

[Android] Add mechanism to disable double tap/drag zooming.

Disabling "built in zoom controls" in Android WebView should disable
double tap to drag as well as pinch to zoom.

BUG=276274
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218701

[mnaganov (inactive), 2013-08-20 14:19:42]

LGTM

[benm (inactive), 2013-08-20 16:55:14]

PTAL kibeom!

Thanks

[Kibeom Kim (inactive), 2013-08-20 17:47:23]

lgtm

[benm (inactive), 2013-08-20 17:50:25]

Joth PTAL for owners, thanks!

[joth, 2013-08-20 18:24:14]

lgtm

...I thought you meant aw/ OWNERS review at first. But I think you mean content/
? :-)

https://codereview.chromium.org/23346003/diff/6001/android_webview/java/src/o...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/23346003/diff/6001/android_webview/java/src/o...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:172:
public void onGestureZoomSupportChanged(boolean supportsGestureZoom);
seems this change is unrelated to the fix, so could be in its own CL? Although,
it's only touching aw/ code so no additional risk in including this in the M30
merge too I guess.

https://codereview.chromium.org/23346003/diff/6001/content/public/android/jav...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
(right):

https://codereview.chromium.org/23346003/diff/6001/content/public/android/jav...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:1163:
private boolean IsDoubleTapDragDisabled() {
nit: isDouble... (leading lower case i)

[benm (inactive), 2013-08-20 18:38:42]

Thanks!

Sent from my Android
On 20 Aug 2013 19:24, <joth@chromium.org> wrote:
>
> lgtm
>
> ...I thought you meant aw/ OWNERS review at first. But I think you mean
content/
> ? :-)

All the owners! :-)

>
>
>
>
https://codereview.chromium.org/23346003/diff/6001/android_webview/java/src/o...
> File
> android_webview/java/src/org/chromium/android_webview/AwSettings.java
> (right):
>
>
https://codereview.chromium.org/23346003/diff/6001/android_webview/java/src/o...
> android_webview/java/src/org/chromium/android_webview/AwSettings.java:172:
> public void onGestureZoomSupportChanged(boolean supportsGestureZoom);
> seems this change is unrelated to the fix, so could be in its own CL?
> Although, it's only touching aw/ code so no additional risk in including
> this in the M30 merge too I guess.
>

The rename you mean? multi touch didn't make much sense anymore as
double/tap drag only needs one finger :-)

>
https://codereview.chromium.org/23346003/diff/6001/content/public/android/jav...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
> (right):
>
>
https://codereview.chromium.org/23346003/diff/6001/content/public/android/jav...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:1163:
> private boolean IsDoubleTapDragDisabled() {
> nit: isDouble... (leading lower case i)

Gah, will do!

>
> https://codereview.chromium.org/23346003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[joth, 2013-08-20 23:31:06]

On 2013/08/20 18:38:42, benm wrote:
> Thanks!
> 
> Sent from my Android
> On 20 Aug 2013 19:24, <mailto:joth@chromium.org> wrote:
> >
> > lgtm
> >
> > ...I thought you meant aw/ OWNERS review at first. But I think you mean
> content/
> > ? :-)
> 
> All the owners! :-)
> 
> >
> >
> >
> >
>
https://codereview.chromium.org/23346003/diff/6001/android_webview/java/src/o...
> > File
> > android_webview/java/src/org/chromium/android_webview/AwSettings.java
> > (right):
> >
> >
>
https://codereview.chromium.org/23346003/diff/6001/android_webview/java/src/o...
> > android_webview/java/src/org/chromium/android_webview/AwSettings.java:172:
> > public void onGestureZoomSupportChanged(boolean supportsGestureZoom);
> > seems this change is unrelated to the fix, so could be in its own CL?
> > Although, it's only touching aw/ code so no additional risk in including
> > this in the M30 merge too I guess.
> >
> 
> The rename you mean? multi touch didn't make much sense anymore as
> double/tap drag only needs one finger :-)

Indeed. But the bug is fixed without the rename. But, it only touches aw/ files
to may as well land it all at once I agree.

Thanks!

> 
> >
>
https://codereview.chromium.org/23346003/diff/6001/content/public/android/jav...
> > File
> >
>
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
> > (right):
> >
> >
>
https://codereview.chromium.org/23346003/diff/6001/content/public/android/jav...
> >
>
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:1163:
> > private boolean IsDoubleTapDragDisabled() {
> > nit: isDouble... (leading lower case i)
> 
> Gah, will do!
> 
> >
> > https://codereview.chromium.org/23346003/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-08-21 09:21:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/23346003/16001

[commit-bot: I haz the power, 2013-08-21 11:30:57]

Change committed as 218701