|
|
Chromium Code Reviews
DescriptionRevert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ )
Reason for revert:
This CL had broken libFuzzer build for Mac :(
Filed crbug.com/645810
Original issue's description:
> Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.
>
> This also adds the crdmg target after fixing availability warnings.
>
> BUG=none
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
> Cr-Commit-Position: refs/heads/master@{#417725}
TBR=thakis@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=645810
NOPRESUBMIT=true
Committed: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
Cr-Commit-Position: refs/heads/master@{#417860}
Patch Set 1 #
Messages
Total messages: 23 (11 generated)
The CQ bit was checked by mmoroz@chromium.org
Created Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none ========== to ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by thakis@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 ========== to ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 NOPRESUBMIT=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 NOPRESUBMIT=true ========== to ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 NOPRESUBMIT=true ========== to ========== Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 NOPRESUBMIT=true Committed: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877 Cr-Commit-Position: refs/heads/master@{#417860} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877 Cr-Commit-Position: refs/heads/master@{#417860}
Message was sent while issue was closed.
On 2016/09/11 14:43:01, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877 > Cr-Commit-Position: refs/heads/master@{#417860} Thanks Nico! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
