Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2334503002: Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (Closed)

Created:
4 years, 3 months ago by mmoroz
Modified:
4 years, 3 months ago
Reviewers:
Robert Sesek, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. (patchset #4 id:60001 of https://codereview.chromium.org/2325783002/ ) Reason for revert: This CL had broken libFuzzer build for Mac :( Filed crbug.com/645810 Original issue's description: > Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac. > > This also adds the crdmg target after fixing availability warnings. > > BUG=none > NOPRESUBMIT=true > > Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d > Cr-Commit-Position: refs/heads/master@{#417725} TBR=thakis@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645810 NOPRESUBMIT=true Committed: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877 Cr-Commit-Position: refs/heads/master@{#417860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -80 lines) Patch
M chrome/utility/BUILD.gn View 3 chunks +49 lines, -2 lines 0 comments Download
D chrome/utility/safe_browsing/mac/BUILD.gn View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/utility/safe_browsing/mac/crdmg.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
mmoroz
Created Revert of Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.
4 years, 3 months ago (2016-09-11 10:12:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334503002/1
4 years, 3 months ago (2016-09-11 10:12:07 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/257236)
4 years, 3 months ago (2016-09-11 10:19:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334503002/1
4 years, 3 months ago (2016-09-11 12:54:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/257240)
4 years, 3 months ago (2016-09-11 13:02:53 UTC) #10
Nico
lgtm
4 years, 3 months ago (2016-09-11 13:48:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334503002/1
4 years, 3 months ago (2016-09-11 13:48:20 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/257243)
4 years, 3 months ago (2016-09-11 13:55:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334503002/1
4 years, 3 months ago (2016-09-11 14:40:21 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-11 14:41:15 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877 Cr-Commit-Position: refs/heads/master@{#417860}
4 years, 3 months ago (2016-09-11 14:43:01 UTC) #22
mmoroz
4 years, 3 months ago (2016-09-12 08:23:09 UTC) #23
Message was sent while issue was closed.
On 2016/09/11 14:43:01, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
> Cr-Commit-Position: refs/heads/master@{#417860}

Thanks Nico!

Powered by Google App Engine
This is Rietveld 408576698