chrome/browser/geolocation/chrome_geolocation_permission_context_android.h - Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_android.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addresses comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/chrome_geolocation_permission_context.cc ('K') | « chrome/browser/geolocation/chrome_geolocation_permission_context.cc ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc » ('j') | chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_android.h

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h b/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h

index c14f224e8014b3c2c02bc55f206a979a1e26f9ba..a29b76bca561583d83b8870879d47dc1f79bc125 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h

@@ -35,6 +35,17 @@ class ChromeGeolocationPermissionContextAndroid

scoped_ptr<GoogleLocationSettingsHelper> google_location_settings_helper_;

+ private:

+ void CheckMasterLocation(const PermissionRequestID& id,

+ const GURL& requesting_frame,

+ const GURL& embedder,

+ base::Callback<void(bool)> callback);

+ void ProceedDecidePermission(const PermissionRequestID& id,

+ const GURL& requesting_frame,

+ const GURL& embedder,

+ base::Callback<void(bool)> callback);

DISALLOW_COPY_AND_ASSIGN(ChromeGeolocationPermissionContextAndroid);

};