Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3930)

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ups Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc
index afb213cf34353c11985c078dda19866207ee32e1..8df9d7f51ffed364eaa8c6b6556027916d709dc5 100644
--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc
+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc
@@ -26,8 +26,6 @@ void ChromeGeolocationPermissionContextAndroid::DecidePermission(
const GURL& requesting_frame,
const GURL& embedder,
base::Callback<void(bool)> callback) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-
// Check to see if the feature in its entirety has been disabled.
// This must happen before other services (e.g. tabs, extensions)
// get an opportunity to allow the geolocation request.
@@ -46,7 +44,6 @@ void ChromeGeolocationPermissionContextAndroid::PermissionDecided(
const GURL& embedder,
base::Callback<void(bool)> callback,
bool allowed) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
// If Google Apps Location setting is turned off then we ignore
// the 'allow' website setting for this site and instead show
// the infobar to go back to the 'settings' to turn it back on.

Powered by Google App Engine
This is Rietveld 408576698