Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added back some asserts / comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_infobar_delegate.h
diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate.h b/chrome/browser/geolocation/geolocation_infobar_delegate.h
index 6dc4b45e62f14da95e0129a29be9fc36c6c1be9c..e2eaf2c11f4246b7f11de7de4f96995825064e62 100644
--- a/chrome/browser/geolocation/geolocation_infobar_delegate.h
+++ b/chrome/browser/geolocation/geolocation_infobar_delegate.h
@@ -39,6 +39,11 @@ class GeolocationInfoBarDelegate : public ConfirmInfoBarDelegate {
// ConfirmInfoBarDelegate:
virtual bool Accept() OVERRIDE;
+ // Give the InfoBar a chance to do some work before showing
+ // to the user.
+ // Make infobar visible to the user.
bulach 2013/09/04 18:48:53 not quite clear what this comment mean :) perhaps
acleung1 2013/09/05 21:50:16 Oops. Strayed comments from a delete. I think thi
+ virtual void Show(InfoBarService* infobar_service);
+
// Call back to the controller, to inform of the user's decision.
void SetPermission(bool update_content_setting, bool allowed);

Powered by Google App Engine
This is Rietveld 408576698