chrome/browser/geolocation/chrome_geolocation_permission_context.h - Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added back some asserts / comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/google_location_settings_helper.h ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('j') | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context.h

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context.h b/chrome/browser/geolocation/chrome_geolocation_permission_context.h

index 06b324d0e21bba688826007791262660252128e5..3dd3d22e86f19919d9209c4c7cd2a7c63b9336e3 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context.h

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context.h

@@ -84,6 +84,12 @@ class ChromeGeolocationPermissionContext

// Removes any pending InfoBar request.

void CancelPendingInfoBarRequest(const PermissionRequestID& id);

+ // Creates and show an info bar.

+ void CreateInfoBarRequest(const PermissionRequestID& id,

+ const GURL& requesting_frame,

+ const GURL& embedder,

+ base::Callback<void(bool)> callback);

bulach 2013/09/04 18:48:53 nit: indentation

acleung1 2013/09/05 21:50:16 Done.

// These must only be accessed from the UI thread.

Profile* const profile_;

bool shutting_down_;