chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc - Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments / fix tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/chrome_geolocation_permission_context_android.cc ('k') | chrome/browser/geolocation/geolocation_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

index 237a764e7dfeb1e06f60591b9a89c2fc2ad3bfca..5fb8812f4be9a134ab2ddf0d0a47f3edc644d16e 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

@@ -11,6 +11,7 @@

#include "base/bind.h"

#include "base/containers/hash_tables.h"

#include "base/memory/scoped_vector.h"

+#include "base/run_loop.h"

#include "base/synchronization/waitable_event.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/content_settings/host_content_settings_map.h"

@@ -22,6 +23,7 @@

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_profile.h"

+#include "content/public/browser/browser_thread.h"

#include "content/public/browser/navigation_details.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_service.h"

@@ -161,6 +163,8 @@ void GeolocationPermissionContextTests::RequestGeolocationPermission(

requesting_frame,

base::Bind(&GeolocationPermissionContextTests::PermissionResponse,

base::Unretained(this), id));

+ content::BrowserThread::GetBlockingPool()->FlushForTesting();

+ base::RunLoop().RunUntilIdle();

}

void GeolocationPermissionContextTests::CancelGeolocationPermissionRequest(