Construct cc scroll tree from blink [spv2]

Construct cc scroll tree from blink [spv2]

This patch updates PaintArtifactCompositor to create cc's scroll tree
from blink's scroll tree.

PropertyTreeManager::updateScrollOffset is an interesting part of this
patch and is where we resolve the differences between cc's trees and
blink's trees. For example, cc's transform node currently stores
scroll offset in a separate vector, and cc's scroll tree maintains a
separate map of scroll offsets for handling synchronization.

A followup patch will add main thread scrolling reasons. Until then,
a couple simple tests have been added verifying the cc scroll tree
structure. The existing layout tests currently exercise the new scroll
tree code end-to-end.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=644514
Committed: https://crrev.com/a82582195998dc7862dbdac6209965b7d51840da
Cr-Commit-Position: refs/heads/master@{#418650}

[pdr., 2016-09-13 21:32:04]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org, chrishtr@chromium.org, trchen@chromium.org

[pdr., 2016-09-14 00:26:13]

Description was changed from

==========
Construct cc scroll tree from blink [spv2]

This patch updates PaintArtifactCompositor to create cc's scroll tree
from blink's scroll tree.

PropertyTreeManager::updateScrollOffset is an interesting part of this
patch and is where we resolve the differences between cc's trees and
blink's trees. For example, cc's transform node currently stores
scroll offset in a separate vector, and cc's scroll tree maintains a
separate map of scroll offsets for handling synchronization.

A followup patch will add main thread scrolling reasons. Until then,
a couple simple tests have been added verifying the cc scroll tree
structure.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=644514
==========

to

==========
Construct cc scroll tree from blink [spv2]

This patch updates PaintArtifactCompositor to create cc's scroll tree
from blink's scroll tree.

PropertyTreeManager::updateScrollOffset is an interesting part of this
patch and is where we resolve the differences between cc's trees and
blink's trees. For example, cc's transform node currently stores
scroll offset in a separate vector, and cc's scroll tree maintains a
separate map of scroll offsets for handling synchronization.

A followup patch will add main thread scrolling reasons. Until then,
a couple simple tests have been added verifying the cc scroll tree
structure. The existing layout tests currently exercise the new scroll
tree code end-to-end.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=644514
==========

[ajuma, 2016-09-14 14:37:44]

lgtm

[chrishtr, 2016-09-14 17:23:46]

lgtm

https://codereview.chromium.org/2334403002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
(right):

https://codereview.chromium.org/2334403002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:146:
constexpr int kRealRootNodeId = 0;
Please add comments about what these constants are about.

[pdr., 2016-09-14 17:37:21]

Thanks! In we go.

On 2016/09/14 at 17:23:46, chrishtr wrote:
> lgtm
> 
>
https://codereview.chromium.org/2334403002/diff/60001/third_party/WebKit/Sour...
> File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
(right):
> 
>
https://codereview.chromium.org/2334403002/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:146:
constexpr int kRealRootNodeId = 0;
> Please add comments about what these constants are about.
Done

[pdr., 2016-09-14 17:37:24]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-09-14 17:37:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2334403002/#ps80001
(title: "Better comments")

[commit-bot: I haz the power, 2016-09-14 17:37:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:11:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-14 20:14:25]

Description was changed from

==========
Construct cc scroll tree from blink [spv2]

This patch updates PaintArtifactCompositor to create cc's scroll tree
from blink's scroll tree.

PropertyTreeManager::updateScrollOffset is an interesting part of this
patch and is where we resolve the differences between cc's trees and
blink's trees. For example, cc's transform node currently stores
scroll offset in a separate vector, and cc's scroll tree maintains a
separate map of scroll offsets for handling synchronization.

A followup patch will add main thread scrolling reasons. Until then,
a couple simple tests have been added verifying the cc scroll tree
structure. The existing layout tests currently exercise the new scroll
tree code end-to-end.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=644514
==========

to

==========
Construct cc scroll tree from blink [spv2]

This patch updates PaintArtifactCompositor to create cc's scroll tree
from blink's scroll tree.

PropertyTreeManager::updateScrollOffset is an interesting part of this
patch and is where we resolve the differences between cc's trees and
blink's trees. For example, cc's transform node currently stores
scroll offset in a separate vector, and cc's scroll tree maintains a
separate map of scroll offsets for handling synchronization.

A followup patch will add main thread scrolling reasons. Until then,
a couple simple tests have been added verifying the cc scroll tree
structure. The existing layout tests currently exercise the new scroll
tree code end-to-end.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=644514

Committed: https://crrev.com/a82582195998dc7862dbdac6209965b7d51840da
Cr-Commit-Position: refs/heads/master@{#418650}
==========

[commit-bot: I haz the power, 2016-09-14 20:14:26]

Patchset 5 (id:??) landed as
https://crrev.com/a82582195998dc7862dbdac6209965b7d51840da
Cr-Commit-Position: refs/heads/master@{#418650}