Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2334383002: Suppress deprecation warning in CastShellActivity. (Closed)

Created:
4 years, 3 months ago by sanfin
Modified:
4 years, 3 months ago
Reviewers:
slan, halliwell, AndyWu, Simeon
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress deprecation warning in CastShellActivity. setStreamMute() was deprecated in Marshmallow, but this invocation is restricted to Lollipop. Move the logic into a private method and annotate it with @SuppressWarnings. BUG=Internal b/31140436 TEST=Build cast_shell_apk Committed: https://crrev.com/ba8e89e88c6fcc6fbf3eb3842df907a8c9bd9620 Cr-Commit-Position: refs/heads/master@{#418440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java View 2 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Simeon
Starting to clean up the lint errors in Chromecast. This is just the beginning.
4 years, 3 months ago (2016-09-13 21:11:47 UTC) #2
halliwell
On 2016/09/13 21:11:47, Simeon wrote: > Starting to clean up the lint errors in Chromecast. ...
4 years, 3 months ago (2016-09-13 23:46:19 UTC) #3
slan
lgtm
4 years, 3 months ago (2016-09-13 23:52:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334383002/1
4 years, 3 months ago (2016-09-14 00:00:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 00:40:18 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 00:42:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba8e89e88c6fcc6fbf3eb3842df907a8c9bd9620
Cr-Commit-Position: refs/heads/master@{#418440}

Powered by Google App Engine
This is Rietveld 408576698