Landing Recent QUIC changes until Sat Sep 10 00:32:41

Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.

Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/

Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/

Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/

remove unused methods: num_early_frames_received() from the shared code which was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/

Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/

Simplify lifetime management of ValidateClientHelloResultCallback::Result objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/

Use the largest received packet instead of the most recently received packet to calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/

Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/

Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/

Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/

deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/

Committed: https://crrev.com/40f77bbc12f69d345396d96032f635cfa8640ffd
Cr-Commit-Position: refs/heads/master@{#418480}

[Ryan Hamilton, 2016-09-13 20:29:05]

Description was changed from

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804

Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150

Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567

remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl:
https://codereview.chromium.org/2250713004.

Merge instuction: please merge the changes in sequencer to chromium.

Merge internal change: 132449425

Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857

Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769

Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039

Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255

Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281

Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925

deprecate --gfe2_reloadable_flag_quic_enable_app_limited_check


https://codereview.chromium.org/2322233004/

BUG=
==========

to

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/


Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/


Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/


remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/


Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/


Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/


Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/


Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/


Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/


Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/


deprecate --gfe2_reloadable_flag_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/
==========

[Ryan Hamilton, 2016-09-13 20:29:57]

Description was changed from

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/


Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/


Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/


remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/


Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/


Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/


Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/


Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/


Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/


Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/


deprecate --gfe2_reloadable_flag_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/
==========

to

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/


Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/


Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/


remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/


Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/


Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/


Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/


Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/


Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/


Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/


deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/
==========

[Ryan Hamilton, 2016-09-13 20:33:29]

rch@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Ryan Hamilton, 2016-09-13 20:33:33]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 20:34:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:37:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2016-09-13 21:24:44]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 21:25:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2016-09-13 21:31:33]

lgtm

[commit-bot: I haz the power, 2016-09-13 22:41:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:41:16]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ryan Hamilton, 2016-09-13 22:50:55]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 22:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:28:39]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ryan Hamilton, 2016-09-14 00:39:50]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-09-14 00:39:51]

The patchset sent to the CQ was uploaded after l-g-t-m from zhongyi@chromium.org
Link to the patchset: https://codereview.chromium.org/2334363002/#ps80001
(title: "copy constructor")

[commit-bot: I haz the power, 2016-09-14 00:40:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 02:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 02:45:35]

Failed to apply patch for net/quic/core/quic_flags_list.h:
While running git apply --index -3 -p1;
  error: patch failed: net/quic/core/quic_flags_list.h:43
  Falling back to three-way merge...
  Applied patch to 'net/quic/core/quic_flags_list.h' with conflicts.
  U net/quic/core/quic_flags_list.h

Patch:       net/quic/core/quic_flags_list.h
Index: net/quic/core/quic_flags_list.h
diff --git a/net/quic/core/quic_flags_list.h b/net/quic/core/quic_flags_list.h
index
f0db3c3899736347e8e1aba8215aa0b011eec9ce..89f0fdfd996e0193798f50dca84cb46822bebbed
100644
--- a/net/quic/core/quic_flags_list.h
+++ b/net/quic/core/quic_flags_list.h
@@ -43,12 +43,6 @@ QUIC_FLAG(bool, FLAGS_quic_require_handshake_confirmation,
false)
 // If true, Cubic's epoch is shifted when the sender is application-limited.
 QUIC_FLAG(bool, FLAGS_shift_quic_cubic_epoch_when_app_limited, false)
 
-// If true, QUIC will measure head of line (HOL) blocking due between
-// streams due to packet losses on the headers stream.  The
-// measurements will be surfaced via UMA histogram
-// Net.QuicSession.HeadersHOLBlockedTime.
-QUIC_FLAG(bool, FLAGS_quic_measure_headers_hol_blocking_time, true)
-
 // If true, disable pacing in QUIC.
 QUIC_FLAG(bool, FLAGS_quic_disable_pacing_for_perf_tests, false)
 
@@ -72,42 +66,19 @@ QUIC_FLAG(bool, FLAGS_quic_respect_http2_settings_frame,
true)
 QUIC_FLAG(bool, FLAGS_quic_enable_version_35, true)
 
 // If true, re-enables QUIC_VERSION_36.
-QUIC_FLAG(bool, FLAGS_quic_enable_version_36, true)
-
-// If true, enables QUIC_VERSION_36.
 QUIC_FLAG(bool, FLAGS_quic_enable_version_36_v2, true)
 
 // If true, use async codepaths to invoke ProofSource::GetProof.
 QUIC_FLAG(bool, FLAGS_enable_async_get_proof, false)
 
-// If true, QuicAlarm::Update will call a faster UpdateImpl implementation
-// instead of canceling and reregistering the alarm.
-QUIC_FLAG(bool, FLAGS_quic_change_alarms_efficiently, true)
-
 // If true, requires handshake confirmations for all QUIC handshakes with
 // versions less than 33.
 QUIC_FLAG(bool, FLAGS_quic_require_handshake_confirmation_pre33, false)
 
-// If true, fix a bug with which QuicStreamSequencerBuffer can\'t release block
-// memory in time.
-QUIC_FLAG(bool, FLAGS_quic_sequencer_buffer_retire_block_in_time, true)
-
-// Remove obsolete code to force QUIC to go forward secure, now that the server
-// immediately goes forward secure.
-QUIC_FLAG(bool, FLAGS_quic_remove_obsolete_forward_secure, true)
-
 // If true, close QUIC connection explicitly on write error due to packet being
 // too large.
 QUIC_FLAG(bool, FLAGS_quic_close_connection_on_packet_too_large, true)
 
-// If true, close the write side of a QUIC spdy stream when all queued bytes
-// have been written and a FIN has been sent.
-QUIC_FLAG(bool, FLAGS_quic_close_stream_after_writing_queued_data, true)
-
-// If true, close connection with QUIC_TOO_MANY_FRAME_GAPS error when number of
-// gaps in QuicStreamSequenceBuffer exceeds allowed limit.
-QUIC_FLAG(bool, FLAGS_quic_limit_frame_gaps_in_buffer, true)
-
 // If true, v33 QUIC client uses 1 bit to specify 8-byte connection id in
public
 // flag.
 QUIC_FLAG(bool, FLAGS_quic_remove_v33_hacks, true)
@@ -119,10 +90,6 @@ QUIC_FLAG(bool, FLAGS_quic_use_chlo_packet_size, true)
 // If true, defer creation of new connection till its CHLO arrives.
 QUIC_FLAG(bool, FLAGS_quic_buffer_packet_till_chlo, true)
 
-// If true, the connection will check whether it is application-limited, and
-// notify the congestion controller about it.
-QUIC_FLAG(bool, FLAGS_quic_enable_app_limited_check, true)
-
 // Deprecate QuicPacketCreator::next_packet_number_length_ because it's no
 // longer necessary.
 QUIC_FLAG(bool, FLAGS_quic_simple_packet_number_length_2, true)
@@ -169,3 +136,6 @@ QUIC_FLAG(bool,
FLAGS_quic_allow_server_address_change_for_mapped_ipv4, true)
 // If true, disables QUIC version less than 34.
 QUIC_FLAG(bool, FLAGS_quic_disable_pre_34, false)
 
+// When true, decode the packet number from the largest received packet, rather
+// than the most recent.
+QUIC_FLAG(bool, FLAGS_quic_packet_numbers_largest_received, true)

[Ryan Hamilton, 2016-09-14 02:57:46]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-09-14 02:57:47]

The patchset sent to the CQ was uploaded after l-g-t-m from zhongyi@chromium.org
Link to the patchset: https://codereview.chromium.org/2334363002/#ps100001
(title: "Revase")

[commit-bot: I haz the power, 2016-09-14 02:58:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 04:04:29]

Description was changed from

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/


Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/


Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/


remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/


Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/


Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/


Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/


Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/


Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/


Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/


deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/
==========

to

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/


Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/


Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/


remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/


Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/


Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/


Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/


Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/


Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/


Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/


deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/
==========

[commit-bot: I haz the power, 2016-09-14 04:04:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-14 04:06:46]

Description was changed from

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.


Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/


Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/


Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/


remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/


Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/


Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/


Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/


Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/


Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/


Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/


deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/
==========

to

==========
Landing Recent QUIC changes until Sat Sep 10 00:32:41

Update recent QUIC flag changes.

Deprecate FLAGS_quic_limit_frame_gaps_in_buffer.

Merge internal change: 132467804
https://codereview.chromium.org/2341483002/

Deprecate flag FLAGS_quic_sequencer_buffer_retire_block_in_time.

Merge internal change: 132461150
https://codereview.chromium.org/2331343003/

Make DiversificationNonce a std::array

Changing a char[32] to a std::array<char, 32>.  No functional change
intended, not flag-protected

Merge internal change: 132456567
https://codereview.chromium.org/2340583002/

remove unused methods: num_early_frames_received() from the shared code which
was used by chromium only.

Triggered by ref chromium cl: https://codereview.chromium.org/2250713004.

Merge internal change: 132449425
https://codereview.chromium.org/2337063004/

Use unique_ptrs to manage callback lifetimes in some QUIC code

Follow-up to cl/132102408.

This CL eliminates the self-deleting callback pattern from a chunk of
QUIC code and replaces it with explicit unique_ptr ownership of all
callbacks.

Replace self-deleting callbacks with unique_ptr owned callbacks in some
QUIC code.  No functional change intended, not flag-protected.

Merge internal change: 132439857
https://codereview.chromium.org/2339433004/

Simplify lifetime management of ValidateClientHelloResultCallback::Result
objects

The lifetimes of ValidateClientHelloResultCallback::Result objects are
managed by bare new/delete.  These objects are also passed around by
pointer which gives no indication as to who is managing the lifetime,
and many methods are passed both a pointer to a Result object as w
ell as a reference to a sub-object.  This CL eliminates these patterns.

Migrating from bare pointers to unique_ptr in some quic codepaths.  No
functional change intended, not flag-protected.

Merge internal change: 132359769
https://codereview.chromium.org/2338013004/

Use the largest received packet instead of the most recently received packet to
calculate the sequence number from.

Merge internal change: 132350039
https://codereview.chromium.org/2333153003/

Deprecate FLAGS_quic_close_stream_after_writing_queued_data

Merge internal change: 132335255
https://codereview.chromium.org/2338713003/

Deprecate FLAGS_quic_remove_obsolete_forward_secure.

Merge internal change: 132331281
https://codereview.chromium.org/2336803004/

Deprecate FLAGS_quic_change_alarms_efficiently.

Merge internal change: 132330925
https://codereview.chromium.org/2338013003/

deprecate FLAGS_quic_enable_app_limited_check

Merge internal change: 132318066
https://codereview.chromium.org/2340563002/

Committed: https://crrev.com/40f77bbc12f69d345396d96032f635cfa8640ffd
Cr-Commit-Position: refs/heads/master@{#418480}
==========

[commit-bot: I haz the power, 2016-09-14 04:06:47]

Patchset 6 (id:??) landed as
https://crrev.com/40f77bbc12f69d345396d96032f635cfa8640ffd
Cr-Commit-Position: refs/heads/master@{#418480}