Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: src/value-serializer.h

Issue 2334353002: Follow object map transitions when deserializing object properties. (Closed)
Patch Set: static_cast Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/value-serializer.cc » ('j') | test/unittests/value-serializer-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/value-serializer.h
diff --git a/src/value-serializer.h b/src/value-serializer.h
index 97dd0e8420b55d3cd33eed2908ddcd96300a1d2a..f6cead7b14ac2bbd0e62c3d6dbf87897a7f7e377 100644
--- a/src/value-serializer.h
+++ b/src/value-serializer.h
@@ -187,6 +187,10 @@ class ValueDeserializer {
Maybe<double> ReadDouble() WARN_UNUSED_RESULT;
Maybe<Vector<const uint8_t>> ReadRawBytes(int size) WARN_UNUSED_RESULT;
+ // Reads a string if it matches the one provided.
+ // Returns true if this was the case. Otherwise, nothing is consumed.
+ bool ReadExpectedString(Handle<String> expected) WARN_UNUSED_RESULT;
+
// Like ReadObject, but skips logic for special cases in simulating the
// "stack machine".
MaybeHandle<Object> ReadObjectInternal() WARN_UNUSED_RESULT;
@@ -214,7 +218,8 @@ class ValueDeserializer {
* encountered. If successful, returns the number of properties read.
*/
Maybe<uint32_t> ReadJSObjectProperties(Handle<JSObject> object,
- SerializationTag end_tag);
+ SerializationTag end_tag,
+ bool can_use_transitions);
// Manipulating the map from IDs to reified objects.
bool HasObjectWithID(uint32_t id);
« no previous file with comments | « no previous file | src/value-serializer.cc » ('j') | test/unittests/value-serializer-unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698