Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2334343002: [tracing] Fix HostDiscardable dump provider to register on the right thread (Closed)

Created:
4 years, 3 months ago by ssid
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Fix HostDiscardable dump provider to register on the right thread The HostDiscardableSharedMemoryManager is destroyed when shutting down and the dump provider is unregistered. But, the dump provider is registered with no task runner which causes races in memory dumps. This CL fixes it to register on right thread. BUG=643438 Committed: https://crrev.com/74dde3a9ea3fef4b5e302040b7eebea2fd7b9422 Cr-Commit-Position: refs/heads/master@{#418592}

Patch Set 1 #

Patch Set 2 : use Get. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/common/host_discardable_shared_memory_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
ssid
Hi, looks like this could cause crashes on slow reports which show up in the ...
4 years, 3 months ago (2016-09-13 21:47:19 UTC) #2
Primiano Tucci (use gerrit)
don't know too much about lifeftime of discardable manager. +reveman RS-LGTM from my viewpoint
4 years, 3 months ago (2016-09-14 10:48:30 UTC) #4
reveman
lgtm
4 years, 3 months ago (2016-09-14 12:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334343002/1
4 years, 3 months ago (2016-09-14 12:28:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/268327)
4 years, 3 months ago (2016-09-14 12:35:39 UTC) #9
ssid
+avi ptal, thanks.
4 years, 3 months ago (2016-09-14 15:59:24 UTC) #11
Avi (use Gerrit)
lgtm stamp
4 years, 3 months ago (2016-09-14 16:05:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334343002/20001
4 years, 3 months ago (2016-09-14 16:52:08 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 16:56:42 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:58:42 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74dde3a9ea3fef4b5e302040b7eebea2fd7b9422
Cr-Commit-Position: refs/heads/master@{#418592}

Powered by Google App Engine
This is Rietveld 408576698