|
|
Description[tracing] Fix HostDiscardable dump provider to register on the right thread
The HostDiscardableSharedMemoryManager is destroyed when shutting down
and the dump provider is unregistered. But, the dump provider is
registered with no task runner which causes races in memory dumps. This
CL fixes it to register on right thread.
BUG=643438
Committed: https://crrev.com/74dde3a9ea3fef4b5e302040b7eebea2fd7b9422
Cr-Commit-Position: refs/heads/master@{#418592}
Patch Set 1 #Patch Set 2 : use Get. #Messages
Total messages: 22 (12 generated)
ssid@chromium.org changed reviewers: + primiano@chromium.org
Hi, looks like this could cause crashes on slow reports which show up in the crash reports. I think we thought the HostDiscardableSharedMemoryManager was a Leaky instance, but it actually gets deleted.
primiano@chromium.org changed reviewers: + reveman@chromium.org
don't know too much about lifeftime of discardable manager. +reveman RS-LGTM from my viewpoint
lgtm
The CQ bit was checked by primiano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
ssid@chromium.org changed reviewers: + avi@chromium.org
+avi ptal, thanks.
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm stamp
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssid@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2334343002/#ps20001 (title: "use Get.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [tracing] Fix HostDiscardable dump provider to register on the right thread The HostDiscardableSharedMemoryManager is destroyed when shutting down and the dump provider is unregistered. But, the dump provider is registered with no task runner which causes races in memory dumps. This CL fixes it to register on right thread. BUG=643438 ========== to ========== [tracing] Fix HostDiscardable dump provider to register on the right thread The HostDiscardableSharedMemoryManager is destroyed when shutting down and the dump provider is unregistered. But, the dump provider is registered with no task runner which causes races in memory dumps. This CL fixes it to register on right thread. BUG=643438 Committed: https://crrev.com/74dde3a9ea3fef4b5e302040b7eebea2fd7b9422 Cr-Commit-Position: refs/heads/master@{#418592} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/74dde3a9ea3fef4b5e302040b7eebea2fd7b9422 Cr-Commit-Position: refs/heads/master@{#418592} |