Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 233433005: Remove static-initializeres from VelocityTracker (Closed)

Created:
6 years, 8 months ago by jdduke (slow)
Modified:
6 years, 8 months ago
Reviewers:
tdresser
CC:
chromium-reviews, dgozman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove static-initializeres from VelocityTracker The static initializers in VelocityTracker went unflagged until the code was enabled on the Linux bots in r263644 (causing its revert in r263647). Remove the static initializers appropriately. BUG=337142 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263789

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Final cleanup #

Patch Set 4 : git cl format #

Total comments: 4

Patch Set 5 : Code review #

Patch Set 6 : Fix win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M ui/events/gesture_detection/velocity_tracker.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/velocity_tracker.cc View 1 2 3 4 5 8 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
jdduke (slow)
tdresser@: PTAL, thanks.
6 years, 8 months ago (2014-04-14 18:16:51 UTC) #1
tdresser
LGTM with nits. https://codereview.chromium.org/233433005/diff/50001/ui/events/gesture_detection/velocity_tracker.cc File ui/events/gesture_detection/velocity_tracker.cc (right): https://codereview.chromium.org/233433005/diff/50001/ui/events/gesture_detection/velocity_tracker.cc#newcode39 ui/events/gesture_detection/velocity_tracker.cc:39: // hasstopped. We need to detect ...
6 years, 8 months ago (2014-04-14 18:22:21 UTC) #2
jdduke (slow)
https://codereview.chromium.org/233433005/diff/50001/ui/events/gesture_detection/velocity_tracker.cc File ui/events/gesture_detection/velocity_tracker.cc (right): https://codereview.chromium.org/233433005/diff/50001/ui/events/gesture_detection/velocity_tracker.cc#newcode39 ui/events/gesture_detection/velocity_tracker.cc:39: // hasstopped. We need to detect this case so ...
6 years, 8 months ago (2014-04-14 18:40:38 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-14 18:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/233433005/70001
6 years, 8 months ago (2014-04-14 18:41:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 20:23:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-14 20:23:19 UTC) #7
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-14 20:23:48 UTC) #8
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 8 months ago (2014-04-14 20:24:03 UTC) #9
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-14 20:26:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/233433005/90001
6 years, 8 months ago (2014-04-14 20:27:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 21:30:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-14 21:30:42 UTC) #13
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-14 21:51:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/233433005/90001
6 years, 8 months ago (2014-04-14 21:52:12 UTC) #15
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 8 months ago (2014-04-15 04:46:48 UTC) #16
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-15 04:46:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/233433005/90001
6 years, 8 months ago (2014-04-15 04:47:37 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 04:49:08 UTC) #19
Message was sent while issue was closed.
Change committed as 263789

Powered by Google App Engine
This is Rietveld 408576698