Fix async/await memory leak

src/js/harmony-async-await.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils, extrasUtils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
@@ skipping 49 matching lines @@
 // The 'awaited' parameter is the value; the generator stands in
 // for the asyncContext, and .promise is the larger promise under
 // construction by the enclosing async function.
 function AsyncFunctionAwait(generator, awaited, outerPromise) {
   // Promise.resolve(awaited).then(
   //     value => AsyncFunctionNext(value),
   //     error => AsyncFunctionThrow(error)
   // );
   var promise = PromiseCastResolved(awaited);
 
-  var onFulfilled =
-      (sentValue) => %_Call(AsyncFunctionNext, generator, sentValue);
-  var onRejected =
-      (sentError) => %_Call(AsyncFunctionThrow, generator, sentError);
+  var onFulfilled = (sentValue) => {

[adamk, 2016/09/15 22:43:20]

Nit: no need for parens while you're changing this

[Dan Ehrenberg, 2016/09/16 00:36:01]

Done

+    %_Call(AsyncFunctionNext, generator, sentValue);
+    // The resulting Promise is a throwaway, so it doesn't matter what it
+    // resolves to. What is important is that we don't end up keeping the
+    // whole chain of intermediate Promises alive by returning the value
+    // of AsyncFunctionNext, as that would create a memory leak.
+    return;
+  };
+  var onRejected = (sentError) => {

[adamk, 2016/09/15 22:43:20]

ditto

[Dan Ehrenberg, 2016/09/16 00:36:00]

Done

+    %_Call(AsyncFunctionThrow, generator, sentError);
+    // Similarly, returning the huge Promise here would cause a long
+    // resolution chain to find what the exception to throw is, and
+    // create a similar memory leak, and it does not matter what
+    // sort of rejection this intermediate Promise becomes.
+    return;
+  }
 
   // Just forwarding the exception, so no debugEvent for throwawayCapability
   var throwawayCapability = NewPromiseCapability(GlobalPromise, false);
   // The Promise will be thrown away and not handled, but it shouldn't trigger
   // unhandled reject events as its work is done
   SET_PRIVATE(throwawayCapability.promise, promiseHasHandlerSymbol, true);
   PerformPromiseThen(promise, onFulfilled, onRejected, throwawayCapability);
 
   if (DEBUG_IS_ACTIVE && !IS_UNDEFINED(outerPromise)) {
     if (IsPromise(awaited)) {
@@ skipping 31 matching lines @@
   return RejectPromise(promise, reason, false);
 }
 
 %InstallToContext([
   "async_function_await_caught", AsyncFunctionAwaitCaught,
   "async_function_await_uncaught", AsyncFunctionAwaitUncaught,
   "reject_promise_no_debug_event", RejectPromiseNoDebugEvent,
 ]);
 
 })