Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2334323003: Add a broken page to dummy_benchmark.noisy_benchmark_1 (Closed)

Created:
4 years, 3 months ago by prasadv
Modified:
4 years, 3 months ago
Reviewers:
nednguyen, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a broken page to dummy_benchmark.noisy_benchmark_1 *PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1 for intergration testing purpose. BUG=646628 NOTRY=true Committed: https://crrev.com/522a347da44b43e8bbf58ad29e246dc3dab3872c Cr-Commit-Position: refs/heads/master@{#418971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/perf/benchmarks/dummy_benchmark.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
prasadv
4 years, 3 months ago (2016-09-13 23:45:30 UTC) #3
nednguyen
lgtm
4 years, 3 months ago (2016-09-13 23:58:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334323003/1
4 years, 3 months ago (2016-09-15 19:14:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/builds/337)
4 years, 3 months ago (2016-09-15 20:43:00 UTC) #8
nednguyen
On 2016/09/15 20:43:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-15 20:53:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334323003/1
4 years, 3 months ago (2016-09-15 20:58:13 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 21:04:19 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/522a347da44b43e8bbf58ad29e246dc3dab3872c Cr-Commit-Position: refs/heads/master@{#418971}
4 years, 3 months ago (2016-09-15 21:06:32 UTC) #19
prasadv
4 years, 3 months ago (2016-09-16 23:03:28 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2345393002/ by prasadv@chromium.org.

The reason for reverting is: Reverting the changes to as we have enough
revisions to perform bisect FYI jobs.

Powered by Google App Engine
This is Rietveld 408576698