|
|
Created:
4 years, 3 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove whitelist entry for v8 test files
We no longer read the sources from the gyp files
BUG=646794
R=machenbach@chromium.org,brettw@chromium.org
Committed: https://crrev.com/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9
Cr-Commit-Position: refs/heads/master@{#419432}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 18 (9 generated)
The CQ bit was checked by brettw@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
(still needs a v8 roll)
lgtm - given the v8 side lands
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org, machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2334303004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove whitelist entry for v8 test files We no longer read the sources from the gyp files BUG=646794 R=machenbach@chromium.org,brettw@chromium.org ========== to ========== Remove whitelist entry for v8 test files We no longer read the sources from the gyp files BUG=646794 R=machenbach@chromium.org,brettw@chromium.org Committed: https://crrev.com/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9 Cr-Commit-Position: refs/heads/master@{#419432} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9 Cr-Commit-Position: refs/heads/master@{#419432} |