Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2334303004: Remove whitelist entry for v8 test files (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove whitelist entry for v8 test files We no longer read the sources from the gyp files BUG=646794 R=machenbach@chromium.org,brettw@chromium.org Committed: https://crrev.com/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9 Cr-Commit-Position: refs/heads/master@{#419432}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M .gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-14 14:00:38 UTC) #1
brettw
lgtm
4 years, 3 months ago (2016-09-14 17:04:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334303004/1
4 years, 3 months ago (2016-09-14 17:04:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/30542) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-14 17:08:05 UTC) #6
jochen (gone - plz use gerrit)
(still needs a v8 roll)
4 years, 3 months ago (2016-09-14 17:10:13 UTC) #7
Michael Achenbach
lgtm - given the v8 side lands
4 years, 3 months ago (2016-09-14 18:36:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334303004/20001
4 years, 3 months ago (2016-09-19 11:38:03 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 11:46:41 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 11:48:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9
Cr-Commit-Position: refs/heads/master@{#419432}

Powered by Google App Engine
This is Rietveld 408576698