Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2334283004: Change explanation string for the Subresource Filter prompt. (Closed)

Created:
4 years, 3 months ago by melandory
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change explanation string for the Subresource Filter prompt. xib changes: ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message. BUG=646742 Committed: https://crrev.com/6c95418d929fb2396581c1dcb10494507e6479ee Cr-Commit-Position: refs/heads/master@{#419118}

Patch Set 1 : . #

Patch Set 2 : add connection to xib #

Total comments: 2

Patch Set 3 : adressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M chrome/app/nibs/ContentSubresourceFilter.xib View 1 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 2 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (21 generated)
melandory
PTAL, screenshot in in the attachment to the bug.
4 years, 3 months ago (2016-09-15 15:01:31 UTC) #14
melandory
On 2016/09/15 15:01:31, melandory wrote: > PTAL, screenshot in in the attachment to the bug. ...
4 years, 3 months ago (2016-09-15 15:07:47 UTC) #15
Nico
lgtm, but please add a "xib changes:" section that describes what you did in IB. ...
4 years, 3 months ago (2016-09-15 19:26:21 UTC) #18
Nico
https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode792 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:792: nit: i wouldn't put a newline here
4 years, 3 months ago (2016-09-15 19:26:50 UTC) #19
melandory
https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm#newcode792 chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:792: On 2016/09/15 19:26:50, Nico wrote: > nit: i wouldn't ...
4 years, 3 months ago (2016-09-15 19:55:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334283004/60001
4 years, 3 months ago (2016-09-16 05:56:47 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-16 06:58:31 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 07:01:37 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c95418d929fb2396581c1dcb10494507e6479ee
Cr-Commit-Position: refs/heads/master@{#419118}

Powered by Google App Engine
This is Rietveld 408576698