|
|
DescriptionChange explanation string for the Subresource Filter prompt.
xib changes:
ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message.
BUG=646742
Committed: https://crrev.com/6c95418d929fb2396581c1dcb10494507e6479ee
Cr-Commit-Position: refs/heads/master@{#419118}
Patch Set 1 : . #Patch Set 2 : add connection to xib #
Total comments: 2
Patch Set 3 : adressed comments #
Messages
Total messages: 29 (21 generated)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Description was changed from ========== Fix mac title BUG=646742 ========== to ========== Change explanation string for the Subresource Filter prompt. BUG=646742 ==========
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
melandory@chromium.org changed reviewers: + thakis@chromium.org
PTAL, screenshot in in the attachment to the bug.
On 2016/09/15 15:01:31, melandory wrote: > PTAL, screenshot in in the attachment to the bug. There is an issue with Xib file, I haven't edited it with the correct combination of XCode and OSX. I would like to proceed with CL, since we want to try to merge it to M54 once it's landed. I'm getting loaner later this week and will flush it to correct version of OSX, then I can change the formatting and create another CL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, but please add a "xib changes:" section that describes what you did in IB. see `git log --grep="xib changes"` for many examples.
https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa... File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:792: nit: i wouldn't put a newline here
Description was changed from ========== Change explanation string for the Subresource Filter prompt. BUG=646742 ========== to ========== Change explanation string for the Subresource Filter prompt. xib changes: Aligned title and message fields with the Load full side button. Added connection for the message. BUG=646742 ==========
Description was changed from ========== Change explanation string for the Subresource Filter prompt. xib changes: Aligned title and message fields with the Load full side button. Added connection for the message. BUG=646742 ========== to ========== Change explanation string for the Subresource Filter prompt. xib changes: ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message. BUG=646742 ==========
https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa... File chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm (right): https://codereview.chromium.org/2334283004/diff/40001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:792: On 2016/09/15 19:26:50, Nico wrote: > nit: i wouldn't put a newline here Done.
The CQ bit was checked by melandory@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2334283004/#ps60001 (title: "adressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change explanation string for the Subresource Filter prompt. xib changes: ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message. BUG=646742 ========== to ========== Change explanation string for the Subresource Filter prompt. xib changes: ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message. BUG=646742 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Change explanation string for the Subresource Filter prompt. xib changes: ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message. BUG=646742 ========== to ========== Change explanation string for the Subresource Filter prompt. xib changes: ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message. BUG=646742 Committed: https://crrev.com/6c95418d929fb2396581c1dcb10494507e6479ee Cr-Commit-Position: refs/heads/master@{#419118} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6c95418d929fb2396581c1dcb10494507e6479ee Cr-Commit-Position: refs/heads/master@{#419118} |