Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tracing/tracing/value/ui/scalar_span.html

Issue 2334233003: Merge NumericValue into Histogram (Closed)
Patch Set: fix rail_power_metric Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/ui/scalar_span.html
diff --git a/tracing/tracing/value/ui/scalar_span.html b/tracing/tracing/value/ui/scalar_span.html
index dc7f97b199e128fbf64cce2af8927fe32b4b14c0..aee980eb1be9c443864f855c377bb259a0451296 100644
--- a/tracing/tracing/value/ui/scalar_span.html
+++ b/tracing/tracing/value/ui/scalar_span.html
@@ -9,7 +9,6 @@ found in the LICENSE file.
<link rel="import" href="/tracing/ui/base/deep_utils.html">
<link rel="import" href="/tracing/value/histogram.html">
<link rel="import" href="/tracing/value/ui/scalar_context_controller.html">
-<link rel="import" href="/tracing/value/value.html">
<script>
'use strict';
@@ -22,7 +21,7 @@ tr.exportTo('tr.v.ui', function() {
};
/**
- * @param {(undefined|!tr.v.NumericValue|!tr.v.Histogram)} value
+ * @param {undefined|tr.v.ScalarNumeric|tr.v.Histogram} value
* @param {Object=} opt_config
* @param {!tr.b.Range=} opt_config.customContextRange
* @param {boolean=} opt_config.rightAlign
@@ -40,11 +39,6 @@ tr.exportTo('tr.v.ui', function() {
var span = ownerDocument.createElement('tr-v-ui-scalar-span');
- if (value instanceof tr.v.NumericValue) {
- value = value.numeric;
- config.unit = value.unit;
- }
-
var numericValue;
if (value instanceof tr.v.ScalarNumeric) {
span.value = value;
« no previous file with comments | « tracing/tracing/value/ui/related_value_set_span_test.html ('k') | tracing/tracing/value/ui/scalar_span_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698