Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tracing/tracing/metrics/system_health/webview_startup_metric.html

Issue 2334233003: Merge NumericValue into Histogram (Closed)
Patch Set: fix rail_power_metric Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/webview_startup_metric.html
diff --git a/tracing/tracing/metrics/system_health/webview_startup_metric.html b/tracing/tracing/metrics/system_health/webview_startup_metric.html
index e5e4f77f5acebafcc3d3693c75d92f74cdfe59bc..7d47baf0d9cb871b4ff38874470c57754d15e6dc 100644
--- a/tracing/tracing/metrics/system_health/webview_startup_metric.html
+++ b/tracing/tracing/metrics/system_health/webview_startup_metric.html
@@ -8,21 +8,24 @@ found in the LICENSE file.
<link rel="import" href="/tracing/metrics/metric_registry.html">
<link rel="import" href="/tracing/metrics/system_health/utils.html">
<link rel="import" href="/tracing/value/histogram.html">
-<link rel="import" href="/tracing/value/value.html">
<script>
'use strict';
tr.exportTo('tr.metrics.sh', function() {
function webviewStartupMetric(values, model) {
- var startupWallHist = new tr.v.Histogram(
+ var startupWallHist = new tr.v.Histogram('webview_startup_wall_time',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter);
- var startupCPUHist = new tr.v.Histogram(
+ startupWallHist.description = 'WebView startup wall time';
+ var startupCPUHist = new tr.v.Histogram('webview_startup_cpu_time',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter);
- var loadWallHist = new tr.v.Histogram(
+ startupCPUHist.description = 'WebView startup CPU time';
+ var loadWallHist = new tr.v.Histogram('webview_url_load_wall_time',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter);
- var loadCPUHist = new tr.v.Histogram(
+ loadWallHist.description = 'WebView blank URL load wall time';
+ var loadCPUHist = new tr.v.Histogram('webview_url_load_cpu_time',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter);
+ loadCPUHist.description = 'WebView blank URL load CPU time';
// TODO(alexandermont): Only iterate over the processes and threads that
// could contain these events.
@@ -47,14 +50,10 @@ tr.exportTo('tr.metrics.sh', function() {
}
}
- values.addValue(new tr.v.NumericValue('webview_startup_wall_time',
- startupWallHist, {description: 'WebView startup wall time'}));
- values.addValue(new tr.v.NumericValue('webview_startup_cpu_time',
- startupCPUHist, {description: 'WebView startup CPU time'}));
- values.addValue(new tr.v.NumericValue('webview_url_load_wall_time',
- loadWallHist, {description: 'WebView blank URL load wall time'}));
- values.addValue(new tr.v.NumericValue('webview_url_load_cpu_time',
- loadCPUHist, {description: 'WebView blank URL load CPU time'}));
+ values.addHistogram(startupWallHist);
+ values.addHistogram(startupCPUHist);
+ values.addHistogram(loadWallHist);
+ values.addHistogram(loadCPUHist);
}
tr.metrics.MetricRegistry.register(webviewStartupMetric);

Powered by Google App Engine
This is Rietveld 408576698