Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2334233003: Merge NumericValue into Histogram (Closed)
Patch Set: fix rail_power_metric Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/responsiveness_metric.html
diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html
index 231e90b40dac98e118e549a4aa556abad865e2db..a8d08820afff9ee71f5c36774d7d2ca864c6991b 100644
--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html
+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html
@@ -12,7 +12,6 @@ found in the LICENSE file.
<link rel="import" href="/tracing/model/user_model/load_expectation.html">
<link rel="import" href="/tracing/model/user_model/response_expectation.html">
<link rel="import" href="/tracing/value/histogram.html">
-<link rel="import" href="/tracing/value/value.html">
<script>
'use strict';
@@ -60,17 +59,18 @@ tr.exportTo('tr.metrics.sh', function() {
* @param {!Object=} opt_options
*/
function responsivenessMetric(values, model, opt_options) {
- var responseNumeric = new tr.v.Histogram(
+ var responseNumeric = new tr.v.Histogram('response latency',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,
tr.v.HistogramBinBoundaries.createLinear(100, 1e3, 50));
- var throughputNumeric = new tr.v.Histogram(
+ var throughputNumeric = new tr.v.Histogram('animation throughput',
tr.b.Unit.byName.unitlessNumber_biggerIsBetter,
tr.v.HistogramBinBoundaries.createLinear(10, 60, 10));
var frameTimeDiscrepancyNumeric = new tr.v.Histogram(
+ 'animation frameTimeDiscrepancy',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,
tr.v.HistogramBinBoundaries.createLinear(0, 1e3, 50).
addExponentialBins(1e4, 10));
- var latencyNumeric = new tr.v.Histogram(
+ var latencyNumeric = new tr.v.Histogram('animation latency',
tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,
tr.v.HistogramBinBoundaries.createLinear(0, 300, 60));
@@ -136,15 +136,10 @@ tr.exportTo('tr.metrics.sh', function() {
});
});
- values.addValue(new tr.v.NumericValue(
- 'response latency', responseNumeric));
- values.addValue(new tr.v.NumericValue(
- 'animation throughput', throughputNumeric));
- values.addValue(new tr.v.NumericValue(
- 'animation frameTimeDiscrepancy',
- frameTimeDiscrepancyNumeric));
- values.addValue(new tr.v.NumericValue(
- 'animation latency', latencyNumeric));
+ values.addHistogram(responseNumeric);
+ values.addHistogram(throughputNumeric);
+ values.addHistogram(frameTimeDiscrepancyNumeric);
+ values.addHistogram(latencyNumeric);
}
tr.metrics.MetricRegistry.register(responsivenessMetric, {

Powered by Google App Engine
This is Rietveld 408576698