tracing/tracing/metrics/system_health/clock_sync_latency_metric.html - Issue 2334233003: Merge NumericValue into Histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/clock_sync_latency_metric.html

Issue 2334233003: Merge NumericValue into Histogram (Closed)

Patch Set: fix rail_power_metric Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/sample_metric.html ('k') | tracing/tracing/metrics/system_health/clock_sync_latency_metric_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/clock_sync_latency_metric.html

diff --git a/tracing/tracing/metrics/system_health/clock_sync_latency_metric.html b/tracing/tracing/metrics/system_health/clock_sync_latency_metric.html

index 641479ab9ead550f785ca2ea4996ca530698934e..8d3820e77d7a6622d90bb07163e9fc0a0357fb14 100644

--- a/tracing/tracing/metrics/system_health/clock_sync_latency_metric.html

+++ b/tracing/tracing/metrics/system_health/clock_sync_latency_metric.html

@@ -9,7 +9,6 @@ found in the LICENSE file.

-<link rel="import" href="/tracing/value/value.html">

'use strict';

@@ -42,13 +41,12 @@ tr.exportTo('tr.metrics.sh', function() {

targetDomain = domain.toLowerCase();

}

- var hist = new tr.v.Histogram(

+ var hist = new tr.v.Histogram('clock_sync_latency_' + targetDomain,

tr.b.Unit.byName.timeDurationInMs_smallerIsBetter,

tr.v.HistogramBinBoundaries.createExponential(1e-3, 1e3, 30));

+ hist.description = 'Clock sync latency for domain ' + targetDomain;

hist.addSample(latency);

- values.addValue(new tr.v.NumericValue(

- 'clock_sync_latency_' + targetDomain, hist,

- {description: 'Clock sync latency for domain ' + targetDomain}));

+ values.addHistogram(hist);

}