Merge NumericValue into Histogram

tracing/tracing/metrics/blink/gc_metric.html

Index: tracing/tracing/metrics/blink/gc_metric.html
diff --git a/tracing/tracing/metrics/blink/gc_metric.html b/tracing/tracing/metrics/blink/gc_metric.html
index ab0497ee3021a6760115290adf88bab4fb0cd297..ee76d0ca5659f2e6d0bf6065a82c7b7bb806e052 100644
--- a/tracing/tracing/metrics/blink/gc_metric.html
+++ b/tracing/tracing/metrics/blink/gc_metric.html
@@ -10,7 +10,6 @@ found in the LICENSE file.
 <link rel="import" href="/tracing/metrics/metric_registry.html">
 <link rel="import" href="/tracing/metrics/v8/utils.html">
 <link rel="import" href="/tracing/value/histogram.html">
-<link rel="import" href="/tracing/value/value.html">
 
 <script>
 'use strict';
@@ -50,8 +49,8 @@ tr.exportTo('tr.metrics.blink', function() {
   var CUSTOM_BOUNDARIES = tr.v.HistogramBinBoundaries.createLinear(0, 20, 200)
     .addExponentialBins(200, 100);
 
-  function createNumericForTopEventTime() {
-    var n = new tr.v.Histogram(
+  function createNumericForTopEventTime(name) {
+    var n = new tr.v.Histogram(name,
         timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
     n.customizeSummaryOptions({
         avg: true,
@@ -64,8 +63,8 @@ tr.exportTo('tr.metrics.blink', function() {
     return n;
   }
 
-  function createNumericForIdleTime() {
-    var n = new tr.v.Histogram(
+  function createNumericForIdleTime(name) {
+    var n = new tr.v.Histogram(name,
         timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
     n.customizeSummaryOptions({
         avg: true,
@@ -79,8 +78,8 @@ tr.exportTo('tr.metrics.blink', function() {
     return n;
   }
 
-  function createPercentage(numerator, denominator) {
-    var histogram = new tr.v.Histogram(percentage_biggerIsBetter);
+  function createPercentage(name, numerator, denominator) {
+    var histogram = new tr.v.Histogram(name, percentage_biggerIsBetter);
     if (denominator === 0)
       histogram.addSample(0);
     else
@@ -97,11 +96,11 @@ tr.exportTo('tr.metrics.blink', function() {
       isBlinkGarbageCollectionEvent,
       blinkGarbageCollectionEventName,
       function(name, events) {
-        var cpuDuration = createNumericForTopEventTime();
+        var cpuDuration = createNumericForTopEventTime(name);
         events.forEach(function(event) {
           cpuDuration.addSample(event.cpuDuration);
         });
-        values.addValue(new tr.v.NumericValue(name, cpuDuration));
+        values.addHistogram(cpuDuration);
       }
     );
   }
@@ -115,11 +114,11 @@ tr.exportTo('tr.metrics.blink', function() {
       isBlinkGarbageCollectionEvent,
       event => 'blink-gc-total',
       function(name, events) {
-        var cpuDuration = createNumericForTopEventTime();
+        var cpuDuration = createNumericForTopEventTime(name);
         events.forEach(function(event) {
           cpuDuration.addSample(event.cpuDuration);
         });
-        values.addValue(new tr.v.NumericValue(name, cpuDuration));
+        values.addHistogram(cpuDuration);
       }
     );
   }
@@ -157,10 +156,11 @@ tr.exportTo('tr.metrics.blink', function() {
   }
 
   function addIdleTimes(values, model, name, events) {
-    var cpuDuration = createNumericForIdleTime();
-    var insideIdle = createNumericForIdleTime();
-    var outsideIdle = createNumericForIdleTime();
-    var idleDeadlineOverrun = createNumericForIdleTime();
+    var cpuDuration = createNumericForIdleTime(name + '_cpu');
+    var insideIdle = createNumericForIdleTime(name + '_inside_idle');
+    var outsideIdle = createNumericForIdleTime(name + '_outside_idle');
+    var idleDeadlineOverrun = createNumericForIdleTime(
+        name + '_idle_deadline_overrun');
     events.forEach(function(event) {
       var idleTask = tr.metrics.v8.utils.findParent(
           event, tr.metrics.v8.utils.isIdleTask);
@@ -185,15 +185,11 @@ tr.exportTo('tr.metrics.blink', function() {
       outsideIdle.addSample(event.cpuDuration - inside);
       idleDeadlineOverrun.addSample(overrun);
     });
-    values.addValue(new tr.v.NumericValue(
-        name + '_idle_deadline_overrun',
-        idleDeadlineOverrun));
-    values.addValue(new tr.v.NumericValue(
-        name + '_outside_idle', outsideIdle));
-    var percentage = createPercentage(insideIdle.sum,
-                                      cpuDuration.sum);
-    values.addValue(new tr.v.NumericValue(
-        name + '_percentage_idle', percentage));
+    values.addHistogram(idleDeadlineOverrun);
+    values.addHistogram(outsideIdle);
+    var percentage = createPercentage(
+        name + '_percentage_idle', insideIdle.sum, cpuDuration.sum);
+    values.addHistogram(percentage);
   }
 
   return {