Chromium Code Reviews| Index: tools/perf/page_sets/login_helpers/pandora_login.py |
| diff --git a/tools/perf/page_sets/login_helpers/dropbox_login.py b/tools/perf/page_sets/login_helpers/pandora_login.py |
| similarity index 61% |
| copy from tools/perf/page_sets/login_helpers/dropbox_login.py |
| copy to tools/perf/page_sets/login_helpers/pandora_login.py |
| index 8e84981f56ec417048a1d388449fe331872f3ca2..422d97af3b98f1240950a009c9f88077b52ebe0d 100644 |
| --- a/tools/perf/page_sets/login_helpers/dropbox_login.py |
| +++ b/tools/perf/page_sets/login_helpers/pandora_login.py |
| @@ -24,20 +24,13 @@ def LoginAccount(action_runner, credential, |
| account_name, password = login_utils.GetAccountNameAndPassword( |
| credential, credentials_path=credentials_path) |
| - action_runner.Navigate('https://www.dropbox.com/login') |
| + action_runner.Navigate('https://www.pandora.com/account/sign-in') |
| login_utils.InputWithSelector( |
| - action_runner, account_name, 'input[name=login_email]') |
| + action_runner, account_name, 'input[id=login_username]') |
| login_utils.InputWithSelector( |
| - action_runner, password, 'input[name=login_password]') |
| - |
| - # Wait until the "Sign in" button is enabled and then click it. |
| - login_button_selector = '.login-form .login-button' |
| - action_runner.WaitForJavaScriptCondition(''' |
| - (function() { |
| - var loginButton = document.querySelector("%s"); |
| - if (!loginButton) |
| - return false; |
| - return !loginButton.disabled; |
| - })();''' % login_button_selector) |
| - action_runner.ClickElement(selector=login_button_selector) |
| - action_runner.WaitForNavigate() |
| + action_runner, password, 'input[id=login_password]') |
| + |
| + login_button_function = ('document.getElementsByClassName(' |
|
petrcermak
2016/09/14 16:42:56
I would personally just inline this into the actio
rnephew (Reviews Here)
2016/09/20 21:09:54
I like naming it. It makes it easier to understand
|
| + '"onboarding__form__button onboarding__b1 onboarding' |
| + '__form__button--blue loginButton")[0]') |
|
petrcermak
2016/09/14 16:42:56
nit: could you put the last "onboarding" on this l
rnephew (Reviews Here)
2016/09/20 21:09:54
Done.
rnephew (Reviews Here)
2016/09/20 21:09:54
Done.
|
| + action_runner.ClickElement(element_function=login_button_function) |