Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2334223012: Fix failures on content_browser tests on Windows 7. (Closed)

Created:
4 years, 3 months ago by lunalu1
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix failures on content_browser tests on Windows 7 from previous CL (patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ ) BUG=509735 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:win7_blink_dbg,win7_blink_compile_dbg,win7_blink_compile_rel,win7_blink_rel TBR=phoglund@chromium.org Committed: https://crrev.com/2ddb05a880fd136570f4f28a4f65f744ecccc424 Cr-Commit-Position: refs/heads/master@{#419528}

Patch Set 1 : Patch from https://codereview.chromium.org/2310683003/ #

Patch Set 2 : don't use the webrtc sendToTest method, and compare to 'video-input' (and not 'video') #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -56 lines) Patch
M chrome/browser/media/webrtc/webrtc_browsertest_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_browsertest_base.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webrtc/media_devices.js View 1 chunk +0 lines, -24 lines 0 comments Download
M content/browser/webrtc/webrtc_webcam_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 chunks +31 lines, -0 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 35 (24 generated)
lunalu1
Hi, My previous CL caused some windows 7 content browser tests to fail and was ...
4 years, 3 months ago (2016-09-16 16:42:41 UTC) #12
mcasas
On 2016/09/16 16:42:41, loonybear wrote: > Hi, > > My previous CL caused some windows ...
4 years, 3 months ago (2016-09-16 17:06:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334223012/120001
4 years, 3 months ago (2016-09-16 18:49:55 UTC) #17
sky
LGTM
4 years, 3 months ago (2016-09-16 18:50:32 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/261273)
4 years, 3 months ago (2016-09-16 18:58:36 UTC) #20
henrika (OOO until Aug 14)
Please ensure that these bots are green as well. Thanks.
4 years, 3 months ago (2016-09-19 07:39:21 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334223012/140001
4 years, 3 months ago (2016-09-19 16:06:26 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262030)
4 years, 3 months ago (2016-09-19 16:14:16 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334223012/120001
4 years, 3 months ago (2016-09-19 16:55:53 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 3 months ago (2016-09-19 19:22:31 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:03:01 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ddb05a880fd136570f4f28a4f65f744ecccc424
Cr-Commit-Position: refs/heads/master@{#419528}

Powered by Google App Engine
This is Rietveld 408576698