Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: media/gpu/android_video_decode_accelerator.cc

Issue 2334223009: Don't use AVDA for <360p VPx content. (Closed)
Patch Set: comments! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/android_video_decode_accelerator.cc
diff --git a/media/gpu/android_video_decode_accelerator.cc b/media/gpu/android_video_decode_accelerator.cc
index 6e371786589982a5ba4098ef709b199eef6986f5..233d70910822699a47056296371f22119b286be3 100644
--- a/media/gpu/android_video_decode_accelerator.cc
+++ b/media/gpu/android_video_decode_accelerator.cc
@@ -1571,7 +1571,9 @@ AndroidVideoDecodeAccelerator::GetCapabilities(
MediaCodecUtil::IsVp8DecoderAvailable()) {
SupportedProfile profile;
profile.profile = VP8PROFILE_ANY;
- profile.min_resolution.SetSize(0, 0);
+ // Since there is little to no power benefit below 360p, don't advertise
+ // support for it. Let libvpx decode it, and save a MediaCodec instance.
+ profile.min_resolution.SetSize(480, 360);
profile.max_resolution.SetSize(3840, 2160);
// If we know MediaCodec will just create a software codec, prefer our
// internal software decoder instead. It's more up to date and secured
@@ -1585,7 +1587,8 @@ AndroidVideoDecodeAccelerator::GetCapabilities(
if (MediaCodecUtil::IsVp9DecoderAvailable()) {
SupportedProfile profile;
- profile.min_resolution.SetSize(0, 0);
+ // Limit to 360p, like we do for vp8. See above.
+ profile.min_resolution.SetSize(480, 360);
profile.max_resolution.SetSize(3840, 2160);
// If we know MediaCodec will just create a software codec, prefer our
// internal software decoder instead. It's more up to date and secured
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698