Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Remove deprecation warning for now. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
index fa2d80384a7302c397268c1440782f0505a5b810..a3d6e05218c0483bfe3deb9c2fb1028ac54b4ca5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
@@ -32,6 +32,7 @@
#include "bindings/core/v8/DOMWrapperWorld.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/StringOrDictionary.h"
#include "bindings/core/v8/V0CustomElementBinding.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8Document.h"
@@ -351,7 +352,8 @@ static void constructCustomElement(
info.GetIsolate());
V0CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;
Element* element = document->createElementNS(
- namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type,
+ namespaceURI, tagName,
+ StringOrDictionary::fromString(maybeType->IsNull() ? nullAtom : type),
exceptionState);
v8SetReturnValueFast(info, element, document);
}
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/core/core_idl_files.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698