third_party/WebKit/Source/core/dom/Document.h - Issue 2334223005: 2nd arg of document.createElement should be an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core_idl_files.gni ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index b16dc305dc3c74c5f30120d9bc928278b0495b12..755c76072299d81632cdb695be668f888582b3e4 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -90,6 +90,7 @@ class DocumentState;

class DocumentType;

class Element;

class ElementDataCache;

+class ElementCreationOptionsOrString;

class ElementRegistrationOptions;

class Event;

class EventFactoryBase;

@@ -977,8 +978,8 @@ public:

TextAutosizer* textAutosizer();

- Element* createElement(const AtomicString& localName, const AtomicString& typeExtension, ExceptionState&);

- Element* createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, const AtomicString& typeExtension, ExceptionState&);

+ Element* createElement(const AtomicString& localName, const ElementCreationOptionsOrString&, ExceptionState&);

+ Element* createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, const ElementCreationOptionsOrString&, ExceptionState&);

ScriptValue registerElement(ScriptState*, const AtomicString& name, const ElementRegistrationOptions&, ExceptionState&, V0CustomElement::NameSet validNames = V0CustomElement::StandardNames);

V0CustomElementRegistrationContext* registrationContext() { return m_registrationContext.get(); }

V0CustomElementMicrotaskRunQueue* customElementMicrotaskRunQueue();