Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

Issue 2334223005: 2nd arg of document.createElement should be an object (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
index 1ebbac1680fb91be681f1f480f3c831ecf5a8bf7..4385c9cdb18ba4fb9f4abdc1d7bbaded9cf159d3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp
@@ -31,6 +31,7 @@
#include "bindings/core/v8/V0CustomElementConstructorBuilder.h"
#include "bindings/core/v8/DOMWrapperWorld.h"
+#include "bindings/core/v8/ElementCreationOptionsOrString.h"
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/V0CustomElementBinding.h"
#include "bindings/core/v8/V8Binding.h"
@@ -282,7 +283,7 @@ static void constructCustomElement(const v8::FunctionCallbackInfo<v8::Value>& in
ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomElement", info.Holder(), info.GetIsolate());
V0CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;
- Element* element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);
+ Element* element = document->createElementNS(namespaceURI, tagName, ElementCreationOptionsOrString::fromString(maybeType->IsNull() ? nullAtom : type), exceptionState);
v8SetReturnValueFast(info, element, document);
}

Powered by Google App Engine
This is Rietveld 408576698