2nd arg of document.createElement should be an object

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 19 matching lines @@
 #include "core/dom/Document.h"
 
 #include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "bindings/core/v8/HTMLScriptElementOrSVGScriptElement.h"
 #include "bindings/core/v8/Microtask.h"
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/SourceLocation.h"
+#include "bindings/core/v8/StringOrDictionary.h"
 #include "bindings/core/v8/V0CustomElementConstructorBuilder.h"
 #include "bindings/core/v8/V8DOMWrapper.h"
+#include "bindings/core/v8/V8ElementCreationOptions.h"
 #include "bindings/core/v8/V8PerIsolateData.h"
 #include "bindings/core/v8/WindowProxy.h"
 #include "core/HTMLElementFactory.h"
 #include "core/HTMLNames.h"
 #include "core/SVGElementFactory.h"
 #include "core/SVGNames.h"
 #include "core/XMLNSNames.h"
 #include "core/XMLNames.h"
 #include "core/animation/CompositorPendingAnimations.h"
 #include "core/animation/DocumentAnimations.h"
@@ skipping 16 matching lines @@
 #include "core/dom/Attr.h"
 #include "core/dom/CDATASection.h"
 #include "core/dom/ClientRect.h"
 #include "core/dom/Comment.h"
 #include "core/dom/ContextFeatures.h"
 #include "core/dom/DOMImplementation.h"
 #include "core/dom/DocumentFragment.h"
 #include "core/dom/DocumentParserTiming.h"
 #include "core/dom/DocumentType.h"
 #include "core/dom/Element.h"
+#include "core/dom/ElementCreationOptions.h"
 #include "core/dom/ElementDataCache.h"
 #include "core/dom/ElementRegistrationOptions.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContextTask.h"
 #include "core/dom/FrameRequestCallback.h"
 #include "core/dom/IntersectionObserverController.h"
 #include "core/dom/LayoutTreeBuilderTraversal.h"
 #include "core/dom/MainThreadTaskRunner.h"
 #include "core/dom/MutationObserver.h"
@@ skipping 584 matching lines @@
     AtomicString localName = convertLocalName(name);
     if (CustomElement::shouldCreateCustomElement(localName))
       return CustomElement::createCustomElementSync(*this, localName);
     return HTMLElementFactory::createHTMLElement(localName, *this, 0,
                                                  CreatedByCreateElement);
   }
 
   return Element::create(QualifiedName(nullAtom, name, nullAtom), this);
 }
 
+String getTypeExtension(Document* document,
+                        const StringOrDictionary& stringOrOptions,
+                        ExceptionState& exceptionState) {
+  if (stringOrOptions.isNull())
+    return emptyString();
+
+  if (stringOrOptions.isString()) {
+    UseCounter::count(document,
+                      UseCounter::DocumentCreateElement2ndArgStringHandling);
+    return stringOrOptions.getAsString();
+  }
+
+  if (stringOrOptions.isDictionary()) {
+    Dictionary dict = stringOrOptions.getAsDictionary();
+    ElementCreationOptions impl;
+    V8ElementCreationOptions::toImpl(dict.isolate(), dict.v8Value(), impl,
+                                     exceptionState);
+    if (impl.hasIs())
+      return impl.is();
+
+    return toCoreString(dict.v8Value()->ToString());
+  }
+
+  return emptyString();
+}
+
 Element* Document::createElement(const AtomicString& localName,
-                                 const AtomicString& typeExtension,
+                                 const StringOrDictionary& stringOrOptions,
                                  ExceptionState& exceptionState) {
   if (!isValidName(localName)) {
     exceptionState.throwDOMException(
         InvalidCharacterError,
         "The tag name provided ('" + localName + "') is not a valid name.");
     return nullptr;
   }
 
   Element* element;
 
   if (CustomElement::shouldCreateCustomElement(convertLocalName(localName))) {
     element = CustomElement::createCustomElementSync(
         *this, convertLocalName(localName));
   } else if (V0CustomElement::isValidName(localName) && registrationContext()) {
     element = registrationContext()->createCustomTagElement(
         *this, QualifiedName(nullAtom, convertLocalName(localName),
                              xhtmlNamespaceURI));
   } else {
     element = createElement(localName, exceptionState);
     if (exceptionState.hadException())
       return nullptr;
   }
 
-  if (!typeExtension.isEmpty())
+  String typeExtention =
+      getTypeExtension(this, stringOrOptions, exceptionState);
+  if (!typeExtention.isEmpty()) {
     V0CustomElementRegistrationContext::setIsAttributeAndTypeExtension(
-        element, typeExtension);
+        element, AtomicString(typeExtention));
+  }
 
   return element;
 }
 
 static inline QualifiedName createQualifiedName(
     const AtomicString& namespaceURI,
     const AtomicString& qualifiedName,
     ExceptionState& exceptionState) {
   AtomicString prefix, localName;
   if (!Document::parseQualifiedName(qualifiedName, prefix, localName,
@@ skipping 21 matching lines @@
   if (qName == QualifiedName::null())
     return nullptr;
 
   if (CustomElement::shouldCreateCustomElement(qName))
     return CustomElement::createCustomElementSync(*this, qName);
   return createElement(qName, CreatedByCreateElement);
 }
 
 Element* Document::createElementNS(const AtomicString& namespaceURI,
                                    const AtomicString& qualifiedName,
-                                   const AtomicString& typeExtension,
+                                   const StringOrDictionary& stringOrOptions,
                                    ExceptionState& exceptionState) {
   QualifiedName qName(
       createQualifiedName(namespaceURI, qualifiedName, exceptionState));
   if (qName == QualifiedName::null())
     return nullptr;
 
   Element* element;
   if (CustomElement::shouldCreateCustomElement(qName))
     element = CustomElement::createCustomElementSync(*this, qName);
   else if (V0CustomElement::isValidName(qName.localName()) &&
            registrationContext())
     element = registrationContext()->createCustomTagElement(*this, qName);
   else
     element = createElement(qName, CreatedByCreateElement);
 
-  if (!typeExtension.isEmpty())
+  String typeExtention =
+      getTypeExtension(this, stringOrOptions, exceptionState);
+  if (!typeExtention.isEmpty()) {
     V0CustomElementRegistrationContext::setIsAttributeAndTypeExtension(
-        element, typeExtension);
+        element, AtomicString(typeExtention));
+  }
 
   return element;
 }
 
 ScriptValue Document::registerElement(ScriptState* scriptState,
                                       const AtomicString& name,
                                       const ElementRegistrationOptions& options,
                                       ExceptionState& exceptionState,
                                       V0CustomElement::NameSet validNames) {
   HostsUsingFeatures::countMainWorldOnly(
@@ skipping 5636 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif